diff --git a/mininet/link.py b/mininet/link.py index 44c590b..b1dfbfc 100644 --- a/mininet/link.py +++ b/mininet/link.py @@ -122,6 +122,7 @@ class Intf( object ): "Return whether interface is up" if setUp: cmdOutput = self.ifconfig( 'up' ) + # no output indicates success if cmdOutput: error( "Error setting %s up: %s " % ( self.name, cmdOutput ) ) return False diff --git a/mininet/net.py b/mininet/net.py index 2d44af3..d082b00 100755 --- a/mininet/net.py +++ b/mininet/net.py @@ -384,7 +384,7 @@ class Mininet( object ): srcPort, dstPort = topo.port( srcName, dstName ) self.addLink( src, dst, srcPort, dstPort, **params ) info( '(%s, %s) ' % ( src.name, dst.name ) ) - + info( '\n' ) def configureControlNetwork( self ): diff --git a/mininet/node.py b/mininet/node.py index 333dfe7..b4c0013 100644 --- a/mininet/node.py +++ b/mininet/node.py @@ -1190,7 +1190,7 @@ class IVSSwitch(Switch): args.append( self.opts ) logfile = '/tmp/ivs.%s.log' % self.name - + self.cmd( ' '.join(args) + ' >' + logfile + ' 2>&1