lab/mininet
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Avoid modifying keyword parameter dictionary in customized()

Browse Source
This commit is contained in:
Bob Lantz
2012-10-30 16:58:51 -07:00
parent f58f83c043
commit 4b1dc93bcc
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mininet/util.py
+4
View File
@@ -395,8 +395,11 @@ def irange(start, end):
def custom( cls, **params ): def custom( cls, **params ):
"Returns customized constructor for class cls." "Returns customized constructor for class cls."
# Note: we may wish to see if we can use functools.partial() here
# and in customConstructor
def customized( *args, **kwargs): def customized( *args, **kwargs):
"Customized constructor" "Customized constructor"
kwargs = kwargs.copy()
kwargs.update( params ) kwargs.update( params )
return cls( *args, **kwargs ) return cls( *args, **kwargs )
customized.__name__ = 'custom(%s,%s)' % ( cls, params ) customized.__name__ = 'custom(%s,%s)' % ( cls, params )
@@ -432,6 +435,7 @@ def customConstructor( constructors, argStr ):
def customized( name, *args, **params ): def customized( name, *args, **params ):
"Customized constructor, useful for Node, Link, and other classes" "Customized constructor, useful for Node, Link, and other classes"
params = params.copy()
params.update( kwargs ) params.update( kwargs )
if not newargs: if not newargs:
return constructor( name, *args, **params ) return constructor( name, *args, **params )