Add static code checking for style and errors

This required a change to logging, which now uses a singleton pattern.

For all future checkins, 'make codecheck' should pass.
This commit is contained in:
Brandon Heller
2010-01-09 17:59:43 -08:00
parent ca58c896dd
commit 723d068c51
11 changed files with 200 additions and 132 deletions
+5 -2
View File
@@ -11,7 +11,7 @@ A Topo object can be a topology database for NOX, can represent a physical
setup for testing, and can even be emulated with the Mininet package.
'''
from networkx import Graph
from networkx.classes.graph import Graph
class NodeID(object):
@@ -87,6 +87,7 @@ class Edge(object):
class Topo(object):
'''Data center network representation for structured multi-trees.'''
def __init__(self):
'''Create Topo object.
@@ -182,6 +183,7 @@ class Topo(object):
@return dpids list of dpids
'''
def is_switch(n):
'''Returns true if node is a switch.'''
return self.node_info[n].is_switch
@@ -196,6 +198,7 @@ class Topo(object):
@return dpids list of dpids
'''
def is_host(n):
'''Returns true if node is a host.'''
return not self.node_info[n].is_switch
@@ -391,4 +394,4 @@ class LinearTopo(Topo):
self._add_edge(s, s + 1, Edge())
if enable_all:
self.enable_all()
self.enable_all()