Add a few clarifying comments
This commit is contained in:
+5
-2
@@ -337,15 +337,18 @@ class Mininet( object ):
|
|||||||
cls: link class (optional)
|
cls: link class (optional)
|
||||||
params: additional link params (optional)
|
params: additional link params (optional)
|
||||||
returns: link object"""
|
returns: link object"""
|
||||||
|
# Accept node objects or names
|
||||||
node1 = node1 if type( node1 ) != str else self[ node1 ]
|
node1 = node1 if type( node1 ) != str else self[ node1 ]
|
||||||
node2 = node2 if type( node2 ) != str else self[ node2 ]
|
node2 = node2 if type( node2 ) != str else self[ node2 ]
|
||||||
options = dict( params )
|
options = dict( params )
|
||||||
options.setdefault( 'addr1', self.randMac() )
|
# Port is optional
|
||||||
options.setdefault( 'addr2', self.randMac() )
|
|
||||||
if port1 is not None:
|
if port1 is not None:
|
||||||
options.setdefault( 'port1', port1 )
|
options.setdefault( 'port1', port1 )
|
||||||
if port2 is not None:
|
if port2 is not None:
|
||||||
options.setdefault( 'port2', port2 )
|
options.setdefault( 'port2', port2 )
|
||||||
|
# Set default MAC - this should probably be in Link
|
||||||
|
options.setdefault( 'addr1', self.randMac() )
|
||||||
|
options.setdefault( 'addr2', self.randMac() )
|
||||||
cls = self.link if cls is None else cls
|
cls = self.link if cls is None else cls
|
||||||
link = cls( node1, node2, **options )
|
link = cls( node1, node2, **options )
|
||||||
self.links.append( link )
|
self.links.append( link )
|
||||||
|
|||||||
Reference in New Issue
Block a user