lab/mininet
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Loosen test_intfoptions tolerance to 25% for CI (#998)

Browse Source 
Adjusting the tolerance for this test to compensate
for apparent performance variation when running as
part of github actions CI builds/tests.
This commit is contained in:
lantz
2021-01-04 18:25:35 -08:00
committed by GitHub
parent ebdb3a5107
commit dcc39a7b25
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
examples/test/test_intfoptions.py
+5 -3
View File
@@ -13,7 +13,7 @@ class testIntfOptions( unittest.TestCase ):
def testIntfOptions( self ): def testIntfOptions( self ):
"verify that intf.config is correctly limiting traffic" "verify that intf.config is correctly limiting traffic"
p = pexpect.spawn( 'python -m mininet.examples.intfoptions ' ) p = pexpect.spawn( 'python -m mininet.examples.intfoptions ' )
tolerance = .2 # plus or minus 20% tolerance = .25 # plus or minus 25% for cloud CI tests
opts = [ "Results: \['([\d\.]+) .bits/sec", opts = [ "Results: \['([\d\.]+) .bits/sec",
"Results: \['10M', '([\d\.]+) .bits/sec", "Results: \['10M', '([\d\.]+) .bits/sec",
"h(\d+)->h(\d+): (\d)/(\d)," "h(\d+)->h(\d+): (\d)/(\d),"
@@ -30,8 +30,10 @@ class testIntfOptions( unittest.TestCase ):
BW = 10 BW = 10
measuredBw = float( p.match.group( 1 ) ) measuredBw = float( p.match.group( 1 ) )
loss = ( measuredBw / BW ) * 100 loss = ( measuredBw / BW ) * 100
self.assertGreaterEqual( loss, 50 * ( 1 - tolerance ) ) self.assertGreaterEqual( loss, 50 * ( 1 - tolerance ),
self.assertLessEqual( loss, 50 * ( 1 + tolerance ) ) 'loss of %d%% << 50%%' % loss )
self.assertLessEqual( loss, 50 * ( 1 + tolerance ),
'loss of %d%% >> 50%%' % loss )
elif index == 2: elif index == 2:
delay = float( p.match.group( 6 ) ) delay = float( p.match.group( 6 ) )
self.assertGreaterEqual( delay, 15 * ( 1 - tolerance ) ) self.assertGreaterEqual( delay, 15 * ( 1 - tolerance ) )