From e0cd11ab21000ec5f3997bcee9aca61ad064f426 Mon Sep 17 00:00:00 2001
From: Rich Lane <rlane@bigswitch.com>
Date: Thu, 19 Feb 2015 14:54:25 -0800
Subject: [PATCH] cli: don't read/write readline history more than once

Previously, when creating multiple CLI objects, each one would append the
~/.mininet_history file to readline's internal list. When writing the file back
it would be duplicated for each CLI object created. So, over a few mininet runs
the history file would grow exponentially.

This change moves the readline setup code out of the CLI constructor into a
class method and adds a flag to prevent it from being executed more than once.
---
 mininet/cli.py | 34 +++++++++++++++++++++++-----------
 1 file changed, 23 insertions(+), 11 deletions(-)

diff --git a/mininet/cli.py b/mininet/cli.py
index 23aaac5..cd017e4 100644
--- a/mininet/cli.py
+++ b/mininet/cli.py
@@ -56,20 +56,12 @@ class CLI( Cmd ):
         Cmd.__init__( self )
         info( '*** Starting CLI:\n' )
 
-        # Set up history if readline is available
-        try:
-            import readline
-        except ImportError:
-            pass
-        else:
-            history_path = os.path.expanduser('~/.mininet_history')
-            if os.path.isfile(history_path):
-                readline.read_history_file(history_path)
-            atexit.register(lambda: readline.write_history_file(history_path))
-
         if self.inputFile:
             self.do_source( self.inputFile )
             return
+
+        self.setup_readline()
+
         while True:
             try:
                 # Make sure no nodes are still waiting
@@ -84,6 +76,26 @@ class CLI( Cmd ):
             except KeyboardInterrupt:
                 output( '\nInterrupt\n' )
 
+    has_setup_readline = False
+    @classmethod
+    def setup_readline( cls ):
+        "Set up history if readline is available"
+
+        # Only set up readline once to prevent multiplying the history file
+        if cls.has_setup_readline:
+            return
+        cls.has_setup_readline = True
+
+        try:
+            import readline
+        except ImportError:
+            pass
+        else:
+            history_path = os.path.expanduser('~/.mininet_history')
+            if os.path.isfile(history_path):
+                readline.read_history_file(history_path)
+            atexit.register(lambda: readline.write_history_file(history_path))
+
     def emptyline( self ):
         "Don't repeat last command when you hit return."
         pass