diff --git a/bin/mn_run.py b/bin/mn_run.py index 6503c9c..281adaf 100755 --- a/bin/mn_run.py +++ b/bin/mn_run.py @@ -108,10 +108,10 @@ class MininetRunner(object): opts.add_option('--verbosity', '-v', type = 'choice', choices = LEVELS.keys(), default = 'info', help = '[' + ' '.join(LEVELS.keys()) + ']') - opts.add_option('--ip', type = 'string', + opts.add_option('--ip', type = 'string', default = '127.0.0.1', help = '[ip address as a dotted decimal string for a' 'remote controller]') - opts.add_option('--port', type = 'string', + opts.add_option('--port', type = 'string', default = 6633, help = '[port integer for a listening remote' ' controller]') self.options = opts.parse_args()[0] diff --git a/mininet/node.py b/mininet/node.py index 359462b..f29acb5 100644 --- a/mininet/node.py +++ b/mininet/node.py @@ -320,7 +320,8 @@ class KernelSwitch(Switch): ' '.join(self.intfs)) # Run protocol daemon self.cmdPrint('ofprotocol nl:' + str(self.dp) + ' tcp:' + - controllers['c0'].IP()+':'+str(controllers['c0'].port) + + controllers['c0'].IP() + ':' + + str(controllers['c0'].port) + ' --fail=closed 1> ' + ofplog + ' 2>' + ofplog + ' &') self.execed = False # XXX until I fix it @@ -406,9 +407,11 @@ class NOX(Controller): ' '.join(nox_args), cdir = nox_core_dir, **kwargs) + class RemoteController(Controller): - '''Controller running remotely.''' - def __init__(self, name, inNamespace = False, ip_address = None, port = 6633): + '''Controller running outside of Mininet's control.''' + def __init__(self, name, inNamespace = False, ip_address = '127.0.0.1', + port = 6633): '''Init. @param name name to give controller @@ -416,8 +419,6 @@ class RemoteController(Controller): listening @param port the port where the remote controller is listening ''' - if not ip_address: - raise Exception('please set ip_address\n') Controller.__init__(self, name, ip_address = ip_address, port = port) def start(self):