fix(issue-24): resume answers start-up dialogs for every agent, with the same switch as create
resume_session.sh called handle_startup_dialogs only when AGENT=claude and passed no agent, so a resumed agy, grok or codex sat on its directory-trust prompt exactly as the create path did before this branch. The gate is gone and the agent is passed, which is the call create already makes. --no-auto-trust / MAM_AUTO_TRUST apply to resume too. A resumed CLI shows the same trust dialog as a fresh one, in the same directory, with the same consequence for codex (trusting loads the project's local config, hooks and exec policy), and handle_startup_dialogs already reads MAM_AUTO_TRUST - so the only question was whether resume exposes the switch or silently inherits the caller's environment. Exposing it keeps the two skills' contracts identical. The tests run the shipped create/stop/resume scripts against the mock herdr. The mock's pane always shows a ready banner, so they fix the call resume makes (session, timeout, agent, MAM_AUTO_TRUST) by overriding the handler in the sandbox copy of lib.sh, plus one unmodified run showing the real handler is reached for a non-claude agent; which keys a dialog gets is fixed on the create side (S4-S6). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
1 parent
ce802d21c8
commit
0dfbb2cc8a
3 files changed
+138
-15
No files matched your search
@@ -101,17 +101,11 @@ case "$AGENT" in
|
||||
esac
|
||||
|
||||
# 4. Spawn new herdr session + run agent with the saved id
|
||||
case "$AGENT" in
|
||||
claude)
|
||||
START_CMD="herdr new-session -d -s \"$SESSION_NAME\" -x 140 -y 40 -c \"$WORKSPACE\" \"$CMD_FULL\""
|
||||
eval "$START_CMD"
|
||||
# auto-handle trust / bypass dialogs
|
||||
handle_startup_dialogs "$SESSION_NAME" 20
|
||||
;;
|
||||
agy|hermes|grok|opencode|codex)
|
||||
eval "herdr new-session -d -s \"$SESSION_NAME\" -x 140 -y 40 -c \"$WORKSPACE\" \"$CMD_FULL\""
|
||||
;;
|
||||
esac
|
||||
eval "herdr new-session -d -s \"$SESSION_NAME\" -x 140 -y 40 -c \"$WORKSPACE\" \"$CMD_FULL\""
|
||||
# Issue #24: start-up dialogs (trust prompts, blocking notices) are answered for
|
||||
# every agent from the adapter's signatures - the same call create makes.
|
||||
# --no-auto-trust leaves a directory-trust dialog to a human (MAM_AUTO_TRUST=0).
|
||||
handle_startup_dialogs "$SESSION_NAME" 20 "$AGENT"
|
||||
|
||||
# 4. Update agent-sessions.yaml: status running, last_visible_status
|
||||
# (Also automatically publishes a `progress --detail "resumed"` event to the multi-agent-mux-delegate-job registry if a delegate_job_id exists)
|
||||
|
||||
Reference in new issue
Block a user