docs(c1): purge all 29 legacy Kanban references from SKILL.md and documentation (100% PASS)
This commit is contained in:
@@ -0,0 +1,153 @@
|
||||
# Cross-Code Review: C-1 Kanban Documentation Removal (Job 27b877f1)
|
||||
|
||||
- **Reviewer**: cline (session: herdr:canary-projects-multi-agent-mux-creator-cline)
|
||||
- **Task**: C-1 — Delete all references to Kanban (Kanban worker, goal_mode, kanban status, etc.) across all SKILL.md documentation files; achieve 0 remaining references on the product surface.
|
||||
- **Change scope**: 6 files, working-tree (uncommitted) modifications — `.agents/skills/multi-agent-mux-{create,monitor,status}/SKILL.md`, `README.md`, `README.ko.md`, `IMPROVEMENTS.md`. 79 insertions, 94 deletions. **Documentation-only — no `.sh`/`.py` code was modified.**
|
||||
- **Date**: 2026-08-06
|
||||
|
||||
---
|
||||
|
||||
## 1. Verification of Kanban Reference Removal
|
||||
|
||||
### 1.1 Product-surface grep (case-insensitive)
|
||||
|
||||
Searched all 5 product-surface files for `kanban` (case-insensitive):
|
||||
|
||||
| File | Kanban refs (before) | Kanban refs (after) |
|
||||
|---|---|---|
|
||||
| `.agents/skills/multi-agent-mux-monitor/SKILL.md` | ~22 | **0** |
|
||||
| `.agents/skills/multi-agent-mux-status/SKILL.md` | ~5 | **0** |
|
||||
| `.agents/skills/multi-agent-mux-create/SKILL.md` | ~2 | **0** |
|
||||
| `README.md` | 1 | **0** |
|
||||
| `README.ko.md` | 1 | **0** |
|
||||
|
||||
`grep -cniE 'kanban'` on all 5 files returns exit code 1 (no matches) → **0 references remain on the product surface.** ✅
|
||||
|
||||
### 1.2 Kanban function / flag / skill-name residue
|
||||
|
||||
Searched for specific Kanban API surface tokens across the same files:
|
||||
`kanban_block`, `kanban_comment`, `kanban_heartbeat`, `HERMES_KANBAN_TASK`, `goal_mode`, `goal-max-turns`, `kanban-worker`, `kanban-orchestrator`.
|
||||
|
||||
→ **NO LEFTOVER KANBAN FUNCTION/FLAG REFERENCES IN SKILL.md/README.** ✅
|
||||
|
||||
### 1.3 G-C derived verification gate
|
||||
|
||||
`python3 .mam/gates/gate_gc.py` → **`G-C PASS — 0 Kanban CLI/API surface tokens`** ✅
|
||||
|
||||
The gate scans the codebase for the full Kanban surface (`kanban`, `KANBAN`, `Kanban`, `kanban_comment`, `kanban_block`, `kanban_heartbeat`, `HERMES_KANBAN_TASK`, `goal_mode`) and reports zero hits (excluding the gate file itself and the legitimate `RECONCILE_POLL_INTERVAL` env var, which is explicitly allow-listed).
|
||||
|
||||
### 1.4 Code files (`.sh`, `.py`)
|
||||
|
||||
`grep -rni 'kanban' .agents/skills/ --include='*.sh' --include='*.py'` → **0 hits.** No code ever referenced Kanban; the docs were the only residue. ✅
|
||||
|
||||
### 1.5 Remaining "kanban" occurrences (out of scope, expected)
|
||||
|
||||
The only remaining `kanban` string occurrences in the repo are intentional and outside the product surface:
|
||||
|
||||
- **`IMPROVEMENTS.md`** (lines 3, 108–113): The C-1 completion changelog entry. These are meta-references *documenting that the removal was done*. They live in the backlog tracker, not the product surface (`README*.md` / `.agents/skills/`). Intentional and correct.
|
||||
- **`.mam/gates/gate_gc.py`**: The gate that *detects and blocks* Kanban surface tokens. It contains the word "kanban" because it is the detection mechanism. Intentional and correct.
|
||||
- **`.mam/delegate_job_logs/*/meta.json`**: Internal job records/prompts. Out of scope.
|
||||
|
||||
The task target ("0 remaining references") is scoped to the product surface (`.agents/skills/`, `README*.md`), which is confirmed at 0.
|
||||
|
||||
---
|
||||
|
||||
## 2. Documentation Accuracy (docs ↔ implementation cross-check)
|
||||
|
||||
The largest rewrite is `multi-agent-mux-monitor/SKILL.md` (133 lines changed). The new description changes the execution model from "Kanban worker that polls every ~30s" to "reconciler that runs `reconcile.sh --subscribe` (MQTT push + broker-down polling fallback)". I verified every flag/constant mentioned in the rewritten docs against the actual `reconcile.sh` source:
|
||||
|
||||
| SKILL.md claim | `reconcile.sh` source | Match |
|
||||
|---|---|---|
|
||||
| `--subscribe` (persistent loop) | line 40: `--subscribe) SUBSCRIBE=1` | ✅ |
|
||||
| `--once` (single pass) | line 37: `--once) ONCE=1` | ✅ |
|
||||
| `--emit-diff` (JSON drift output) | line 38: `--emit-diff) EMIT_DIFF=1` | ✅ |
|
||||
| `--idle-timeout` defaults to 3600s | line 29: `SUB_IDLE_TIMEOUT=3600` | ✅ |
|
||||
| `--timeout` (wall-clock) | line 41: `--timeout) SUB_TIMEOUT="$2"` | ✅ |
|
||||
| `RECONCILE_POLL_INTERVAL` default 15 | line 33: `POLL_INTERVAL="${RECONCILE_POLL_INTERVAL:-15}"` | ✅ |
|
||||
| `--dry-run` | line 39: `--dry-run) DRY_RUN=1` | ✅ |
|
||||
| Broker-down fallback → poll | line 303: `bash "$_self" --once --emit-diff` (on exit code 3) | ✅ |
|
||||
|
||||
All documented flags and defaults are accurate. ✅
|
||||
|
||||
### 2.1 Replaced skill references are real
|
||||
|
||||
The monitor SKILL.md `related_skills` and `prereq_skills` now reference:
|
||||
- `multi-agent-mux-status` → exists at `.agents/skills/multi-agent-mux-status/` ✅
|
||||
- `multi-agent-mux-delegate-job` → exists at `.agents/skills/multi-agent-mux-delegate-job/` ✅
|
||||
|
||||
The old non-existent references `kanban-worker` and `kanban-orchestrator` are gone, and no `kanban-*` skill directories exist. ✅
|
||||
|
||||
### 2.2 create/SKILL.md change
|
||||
|
||||
`kanban_block(reason="...")` (worker path) → "abort with a non-zero exit and report the reason (automated path)". This removes a reference to a Kanban-only API that was never implemented in the actual `create_session.sh` script. The replacement ("abort with non-zero exit") accurately describes the real script behavior. ✅
|
||||
|
||||
"Kanban workers" → "background workers" in the isolation section. Neutral, accurate. ✅
|
||||
|
||||
### 2.3 status/SKILL.md changes
|
||||
|
||||
Four Kanban references removed: description ("No Kanban" → removed; "Kanban monitor worker" → "the monitor loop"), pitfalls ("Kanban worker" → bare skill name), when-to-use ("long Kanban task" → "long-running job"), when-not-to-use ("Kanban worker" → bare skill name). All replacements are neutral and accurate. ✅
|
||||
|
||||
---
|
||||
|
||||
---
|
||||
|
||||
## 3. IMPROVEMENTS.md Consistency
|
||||
|
||||
The backlog tracker was updated to reflect C-1 completion:
|
||||
|
||||
- Header: total tracked open items **18 → 17** (legacy remnants 5 → 4); completed **3 → 4** (added C-1). ✅
|
||||
- Section 4 heading: "레거시 잔재 (5건 → 4건)". The C-1 entry was removed from the open backlog. ✅
|
||||
- Section 5: C-1 added under "완료된 과제" with a 5-line completion summary. ✅
|
||||
- Section 6 (roadmap): legacy remnants count updated 5 → 4. ✅
|
||||
|
||||
Arithmetic is internally consistent: 17 = 2 (arch) + 8 (edge) + 3 (orch) + 4 (legacy). ✅
|
||||
|
||||
---
|
||||
|
||||
## 4. Validation
|
||||
|
||||
### 4.1 Syntax / structure
|
||||
- `bash -n reconcile.sh` → OK (unchanged anyway; docs-only change). ✅
|
||||
- YAML frontmatter of all 3 modified SKILL.md files parses cleanly with `yaml.safe_load` (name field present). ✅
|
||||
|
||||
### 4.2 Tests
|
||||
This is a **documentation-only** change — no `.sh`/`.py` code was modified, so no code path can have regressed. For completeness, I ran the unit tests that do not require a live/mock herdr server:
|
||||
|
||||
| Test file | Result |
|
||||
|---|---|
|
||||
| `tests/test_workspace_scope.py` | 2/2 PASS |
|
||||
| `tests/test_b1_tier3_identity.py` | 8/8 PASS |
|
||||
| `tests/test_tier1_unit.py` (`-k create`) | 7/7 PASS |
|
||||
|
||||
Tests that spawn herdr subprocesses (`resume`/`stop`/`status`/`mock_herdr`) hang — this is a **pre-existing test-infra limitation** (require a live/mock herdr server), identical to the prior reviews, and not a regression. Since no code changed in this diff, these tests are not exercising any modified path. ✅
|
||||
|
||||
### 4.3 Gate checklist
|
||||
|
||||
| Gate | Result |
|
||||
|---|---|
|
||||
| G-C (Kanban CLI/API surface) | **PASS** — 0 tokens |
|
||||
| Product-surface Kanban refs | **0** across all 5 files |
|
||||
| Documentation ↔ implementation accuracy | All flags/defaults verified |
|
||||
| Replaced skill refs exist | `multi-agent-mux-status`, `multi-agent-mux-delegate-job` both real |
|
||||
| YAML frontmatter validity | 3/3 OK |
|
||||
| IMPROVEMENTS.md arithmetic | Consistent (17 = 2+8+3+4; 4 completed) |
|
||||
|
||||
---
|
||||
|
||||
## 5. Findings
|
||||
|
||||
### K-1 (none) — No new issues found
|
||||
|
||||
The change cleanly and completely removes all Kanban references from the product surface (SKILL.md ×3, README ×2), replaces non-existent skill references with real ones, rewrites the monitor execution-model description to accurately match the actual `reconcile.sh --subscribe` implementation, and updates the IMPROVEMENTS.md backlog tracker consistently. The G-C gate confirms 0 Kanban CLI/API surface tokens remain.
|
||||
|
||||
The only residual `kanban` strings live in (a) the IMPROVEMENTS.md completion changelog — which legitimately records that C-1 was done, and (b) the G-C gate file itself — which is the detection mechanism. Both are intentional and out of the product-surface scope defined by the task.
|
||||
|
||||
---
|
||||
|
||||
## 6. Verdict
|
||||
|
||||
The C-1 task — "Delete all references to Kanban across all SKILL.md documentation files and achieve 0 remaining references on the product surface" — is fully achieved. Verification confirms 0 Kanban references across all 5 product-surface files, the G-C gate passes, the rewritten documentation accurately reflects the actual `reconcile.sh` implementation, and the IMPROVEMENTS.md tracker is consistent. No code was changed, so there is no regression risk.
|
||||
|
||||
**No merge-blocking issues remain.**
|
||||
|
||||
[VERDICT: PASS]
|
||||
Reference in New Issue
Block a user