tmpl/multi-agent-mux
1
0 Fork 0
Code Issues 10 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

release(v4.8.2): bump framework and eight skills to 4.8.2 in lockstep; archive the follow-up loop's reports

Browse Source 
PR #41/#43 review follow-ups F1-F6, implemented by creator-claude-01 in a
loop and reviewed by claude, agy, grok and codex: round 1 (@95eabc6)
codex NOT PASS (a failed env load cached as loaded), fixed in 75f364e;
round 2 4/4 PASS. Full suite at 75f364e 1380 passed / 0 failed. Reviewer
reports (round 2 with identity sidecars) and the creator's reports go to
.agents/reports/<session>/.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VCgu9Fa9iT7TbJUSzdq4Ff
This commit is contained in:
GodopuandClaude Opus 5.5 committed 2026-10-03 00:27:24 +09:00
1 parent 75f364e4b4
commit 3563a6fc17
30 files changed
+927 -26
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

.agents/reports/reviewer-agy-01/report-701757db.identity.json
+14
View File
@@ -0,0 +1,14 @@
{
"loop_id": "loop-20261001T230324Z-b511bf",
"base_sha": "0051fd6c3b088f8b265928ccd94ea31053fdde7e",
"head_sha": "75f364e4b47d8db95ce2a7e041b69b8e8b473e64",
"tree_sha": "ec1fdc453ec6fdf2c09165c92a64d54e684f5a3a",
"review_commit": "75f364e4b47d8db95ce2a7e041b69b8e8b473e64",
"reviewer": "reviewer-agy-01",
"job_id": "701757db",
"verdict": "PASS",
"transport": "herdr",
"evidence": "review-tree",
"isolation": "worktree",
"verified_at": "2026-10-02T00:58:55Z"
}
.agents/reports/reviewer-agy-01/report-701757db.md
+105
View File
@@ -0,0 +1,105 @@
# Final Review Report: Job 701757db (Round 2)
## 1. Review Identity & Metadata
- **Loop ID**: `loop-20261001T230324Z-b511bf`
- **Job ID**: `701757db`
- **Reviewer**: agy (session: `herdr:reviewer-agy-01`)
- **Base Commit**: `0051fd6c3b088f8b265928ccd94ea31053fdde7e`
- **Head Commit**: `75f364e4b47d8db95ce2a7e041b69b8e8b473e64` (9 commits)
- **Tree Hash**: `ec1fdc453ec6fdf2c09165c92a64d54e684f5a3a`
- **Verification Path**: `/var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2`
- **Git Status**: Clean (no uncommitted or untracked changes)
- **Git Diff Whitespace Check (`git diff base...HEAD --check`)**: Clean (0 errors)
---
## 2. Commit Range Audit (base..head)
The branch contains 9 atomic commits implementing requirements F1–F6 plus review follow-up R1:
1. `75936f1`: `test(followups): F1 - A8 writes the marker lstart as loop_lock.sh reads it`
2. `5edf913`: `fix(followups): F2 - Python entry points report an unreadable env file in one line`
3. `71ea809`: `fix(followups): F3 - .mam.env BOM, repeated keys and a missing MAM_ENV_FILE`
4. `8b04639`: `fix(followups): F4a/F4c - the runner's wait knobs follow the integer rule; MAM_WAIT_GRACE_S documented`
5. `fb1b93c`: `fix(followups): F4b - bash integer knobs that reach [ -ge/-le/-gt ] or sleep go through mam_int_knob`
6. `c252ac4`: `fix(followups): F5 - no test switch in the stall watcher`
7. `1e92ddc`: `test(followups): F6 - the wrapper vanishes inside the second wait; the <= 60 s is the herdr wait's`
8. `95eabc6`: `fix(followups): F2 - job_subscriber returns the env-file failure by name`
9. `75f364e`: `fix(followups): F2 review R1 - a failed env load is not cached as loaded`
---
## 3. Requirement Verification & Findings
### F1: Date-dependent Test Bug Resolution
- **Issue**: `tests/test_issue21_acceptance.py::test_a8_second_loop_is_refused_before_a_scheduler_exists` failed on calendar days 1–9 due to `ps -o lstart=` double-space padding vs `mam_lstart` single-space normalization (`tr -s ' '`).
- **Implementation**:
- `_marker_lstart` normalizes ps output with `" ".join(out.split())` in [`tests/test_issue21_acceptance.py`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/tests/test_issue21_acceptance.py#L554-L559).
- Parameterized with `_PADDED_PS` shim to deterministically test single-digit day padding across all runs.
- **Verification**: `test_issue21_acceptance.py` passes completely (10/10 passed).
### F2: Python Entry Point EnvFileError Reporting & Retry Behavior (including R1)
- **Issue**: Missing/unreadable `.mam.env` should produce a single error line (`ERROR: <path>: cannot read (<exception type>)`) and exit with returncode 1, without a Python traceback or leaking secrets. Furthermore, a failed load must not be cached as loaded so subsequent entry point invocations in the same process can retry or fail consistently.
- **Implementation**:
- [`load_env_or_report()`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/.agents/skills/lib_py/delegation/mqtt_common.py#L130-L141) wraps `ensure_env_loaded()` and prints `ERROR: <e>` to `sys.stderr` returning `False`.
- In [`mqtt_common.py`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/.agents/skills/lib_py/delegation/mqtt_common.py#L125), `_env_loaded = True` is only assigned after `_load_dotenv()` successfully completes.
- All process entry points (`publish_event`, `registry`, `job_subscriber`, `cli`, `bench`, `heartbeat`, `remote`) guard their main functions with `if not mqtt_common.load_env_or_report(): return 1`.
- Added [`test_a1_a_failed_load_is_not_cached_as_loaded`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/tests/test_issue26_envfile.py#L721-L740) validating that consecutive invocations with broken files fail with rc 1 and do not register jobs, and once repaired, reload and succeed.
- Updated documentation in [`MESSAGING.md`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/MESSAGING.md#L509-L511).
- **Verification**: `tests/test_issue26_envfile.py` passes all 38 tests.
### F3: `.mam.env` Refinements
- **Implementation**:
- `parse()` in [`lib_py/delegation/envfile.py`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/.agents/skills/lib_py/delegation/envfile.py#L58) uses `utf-8-sig` encoding, properly ignoring leading BOMs.
- Repeated keys retain their first defined value, documented in [`.mam.env.example`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/.mam.env.example#L497).
- Missing `MAM_ENV_FILE` is skipped silently without falling back to ambient search.
- **Verification**: Regression tests `test_a7_a_leading_bom_is_not_part_of_the_first_key`, `test_a7_a_repeated_key_keeps_its_first_value_as_documented`, and `test_a7_a_missing_explicit_file_loads_nothing_and_says_nothing` all pass.
### F4: Integer Knob Expansion & `lib_int.sh`
- **Implementation**:
- Created standalone [`.agents/skills/lib_int.sh`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/.agents/skills/lib_int.sh) containing `mam_int` and `mam_int_knob`. Added to [`deploy/remove.sh`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/deploy/remove.sh#L85).
- Sourced by scripts executed with and without `lib.sh` ([`loop_lock.sh`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/.agents/skills/multi-agent-mux-loop/scripts/loop_lock.sh), [`diff_collect.sh`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/.agents/skills/multi-agent-mux-loop/scripts/diff_collect.sh), [`lib.sh`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/.agents/skills/lib.sh), [`reconcile.sh`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/.agents/skills/multi-agent-mux-monitor/scripts/reconcile.sh)).
- Python loop runner [`LoopRunner._int_knob`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/.agents/skills/lib_py/loop/runner.py#L355) parses `MAM_WAIT_GRACE_S`, `MAM_CHILD_WAIT_S`, and `MAM_JOB_TREE_MAX`, falling back cleanly to defaults upon invalid input.
- Documented in [`multi-agent-mux-loop/SKILL.md`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/.agents/skills/multi-agent-mux-loop/SKILL.md#L427).
- Fractional float nature of `SKS_QUIESCENT_INTERVAL` is preserved and documented in `NOT_ARITHMETIC`.
- **Verification**: `tests/test_issue26_ints.py` passes all 93 test cases.
### F5: Removal of Test Hooks in Production Code
- **Implementation**:
- Removed `MAM_TEST_UNRELIABLE_AGENT` from [`lib_py/stall_watch.py`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/.agents/skills/lib_py/stall_watch.py).
- [`tests/test_issue30_stall_watch.py`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/tests/test_issue30_stall_watch.py#L924-L938) sets `adapter.agent_status_reliable = property(lambda self: False)` via test-side injection.
- **Verification**: `test_s13_the_unreliable_case_needs_no_switch_in_the_product` and all 48 stall watch tests pass.
### F6: Documentation Precision & Mid-Wait Termination Testing
- **Implementation**:
- Refined `<= 60 s` comment in [`multi-agent-mux-delegate-job/SKILL.md`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/.agents/skills/multi-agent-mux-delegate-job/SKILL.md#L412) to specifically denote herdr wait duration.
- Added `in_wait` hook in [`tests/test_issue30_stall_watch_stop.py`](file:///var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2/tests/test_issue30_stall_watch_stop.py#L979-L1018) ensuring deterministic termination during the second wait tick.
- **Verification**: All 11 tests in `test_issue30_stall_watch_stop.py` pass cleanly.
---
## 4. Test Suite Execution Results
All required test suites were executed inside the verification path (`/var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/2`) using Python venv with `--basetemp=/tmp/pytest-followups-clean`:
| Test Suite | Result | Time |
|---|---|---|
| `tests/test_issue26_envfile.py` | 38 passed | 8.26 s |
| `tests/test_issue26_ints.py` | 93 passed | 38.29 s |
| `tests/test_issue30_stall_watch_stop.py` + `tests/test_version_consistency.py` | 14 passed | 31.16 s |
| `tests/test_tier1_unit.py` | 67 passed | 59.75 s |
| `tests/test_issue21_acceptance.py` | 10 passed | 39.56 s |
| `tests/test_issue30_stall_watch.py` | 48 passed, 1 skipped | 263.44 s |
**Total Tests**: 270 passed, 1 skipped, 0 failed.
---
## 5. Scope & Quality Checks
- **Out-of-Scope Modifications**: None. No version bump, no push/merge/PR creation, no extraneous refactoring.
- **Security & Secret Handling**: No secrets or credential values printed or logged.
- **Whitespace & Formatting**: Zero errors reported by `git diff base...HEAD --check`.
All completion criteria for F1–F6 and review follow-up R1 are fully met with comprehensive test coverage.
[VERDICT: PASS]
.agents/reports/reviewer-agy-01/report-dd9ea82f.md
+110
View File
@@ -0,0 +1,110 @@
# Code Review Report: PR #41 / PR #43 Follow-ups (`fix/followups-41-43`)
- **Job ID**: `dd9ea82f`
- **Target / Session**: `agy` (`herdr:reviewer-agy-01`)
- **Role**: Reviewer
- **Review Identity**:
- `loop_id`: `loop-20261001T230324Z-b511bf`
- `base`: `0051fd6c3b088f8b265928ccd94ea31053fdde7e` (main, HEAD at loop start)
- `head`: `95eabc693f7346f491592b053487bdcf0acd5f4f`
- `tree`: `46399844fa63d62d97f7b52ee35010f2fa1b7998`
- Verification Path: `/var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/1`
---
## 1. Executive Summary
This review audits the follow-up changes addressing residual items from PR #41 (v4.8.0) and PR #43 (v4.8.1).
The changes encompass 8 atomic commits on branch `fix/followups-41-43`, addressing items **F1** through **F6**.
All 6 items are implemented surgically, verified with deterministic regression tests, and maintain clean separation of concerns without introducing out-of-scope changes:
- **F1**: Resolved the date-dependent `ps -o lstart=` double-space padding mismatch in `test_issue21_acceptance.py`.
- **F2**: Standardized Python entry point error reporting for unreadable `.mam.env` files to print a single `ERROR:` line with exit code 1 (no traceback or credential leaks), without library code invoking `sys.exit`.
- **F3**: Added UTF-8 BOM (`utf-8-sig`) handling, documented first-value precedence for duplicate keys in `.mam.env.example`, and aligned `MESSAGING.md` documentation with actual file search semantics.
- **F4**: Unified integer knobs across Python and Bash (`lib_int.sh`), eliminating `ValueError` and shell arithmetic syntax errors on non-integer inputs, while preserving fractional seconds where appropriate (`SKS_QUIESCENT_INTERVAL`).
- **F5**: Removed the `MAM_TEST_UNRELIABLE_AGENT` test switch from production code in `stall_watch.py` and converted `test_s13` to mock adapter properties dynamically in the test process.
- **F6**: Clarified herdr wait bounds in `SKILL.md` and hardened the mid-wait wrapper termination test in `test_issue30_stall_watch_stop.py`.
All relevant test suites executed in the isolated verification path passed 100%.
---
## 2. Item-by-Item Detailed Audit
### 2.1. F1: Date-dependent Test Bug (`test_issue21_acceptance.py`)
- **Root Cause**: `ps -p <pid> -o lstart=` pads single-digit day numbers with a leading space (e.g. `"Oct 1"`), whereas `loop_lock.sh`'s `mam_lstart` compresses whitespace using `tr -s ' '` (`"Oct 1"`). When `test_a8_second_loop_is_refused_before_a_scheduler_exists` wrote raw `ps` output to the lock marker on days 1–9 of any month, the strings diverged, causing false lock staleness detections.
- **Implementation**:
- `tests/test_issue21_acceptance.py#L549-L554`: Added `_marker_lstart(pid, env)` which normalizes `lstart` via `" ".join(out.split())` matching `mam_lstart`.
- Added `_PADDED_PS` shim (`#L541-L547`) to test both `"real"` and forced `"padded"` scenarios parametrically (`#L556-L587`).
- Production code `loop_lock.sh` was appropriately left untouched.
### 2.2. F2: Python Entry Points' Single-Line `EnvFileError` Output
- **Implementation**:
- Added `load_env_or_report() -> bool` in `lib_py/delegation/mqtt_common.py#L279-L290`. When `EnvFileError` is caught, it prints `ERROR: {e}` to `sys.stderr` and returns `False`.
- Process entry points (`publish_event.py`, `registry.py`, `job_subscriber.py`, `cli.py`, `bench.py`, `heartbeat.py`, `remote.py`) call `load_env_or_report()` and exit with code 1 (`RC_ERROR` in `job_subscriber.py`).
- Library functions (`ensure_env_loaded()`, `_parse_env_file()`) never call `sys.exit()` directly.
- Secret safety: Neither file contents nor variable values are printed.
- Test coverage: `tests/test_issue26_envfile.py#L606-L645` (`test_a1_python_entry_points_report_an_unreadable_file_in_one_line`) tests all 7 modules under permission denial (`chmod 000`) and invalid UTF-8 decoding, verifying exact error format and absence of tracebacks.
### 2.3. F3: `.mam.env` Parser & Documentation Refinements
- **Implementation**:
- (a) **UTF-8 BOM**: `lib_py/delegation/envfile.py#L215` opens files with `encoding="utf-8-sig"`, automatically stripping any leading BOM (`\xef\xbb\xbf`) so the first key is not rejected as invalid. Verified by `test_a7_a_leading_bom_is_not_part_of_the_first_key`.
- (b) **Duplicate Keys**: Added explicit documentation in `.mam.env.example#L492`: `"a key given twice keeps its FIRST value (a later line does not replace it);"`. Verified by `test_a7_a_repeated_key_keeps_its_first_value_as_documented`.
- (c) **Documentation Alignment**: Updated `MESSAGING.md#L505` to describe actual behavior: non-existent `MAM_ENV_FILE` is skipped silently (falling back to environment and defaults, without ambient parent directory walk), while an unreadable file raises `EnvFileError` and exits 1. Verified by `test_a7_a_missing_explicit_file_loads_nothing_and_says_nothing`.
### 2.4. F4: Integer Knob Expansion & Normalization
- **Python Runner Knobs (`lib_py/loop/runner.py`)**:
- Added `LoopRunner._int_knob(name, minimum)` (`#L350-L362`) leveraging `_positive_int`. Invalid values log a single warning to `sys.stderr` and fall back to defaults, preventing `ValueError` crashes.
- Knobs configured: `MAM_WAIT_GRACE_S` (min 0, default 300), `MAM_CHILD_WAIT_S` (min 0, default `job_budget + grace`), `MAM_JOB_TREE_MAX` (min 1, default 50).
- Documented `MAM_WAIT_GRACE_S` in `multi-agent-mux-loop/SKILL.md#L422`, `#L431`.
- **Bash Normalization & `lib_int.sh`**:
- Extracted integer normalization logic into dedicated `.agents/skills/lib_int.sh` (`#L1-L39`), sourced by `lib.sh`, `loop_lock.sh`, and `diff_collect.sh`. Added to `deploy/remove.sh#L517`.
- Normalized knobs:
- `MAM_READY_EMPTY_GIVEUP`: min 1, default 5 (`lib.sh#L2417`)
- `SKS_EMPTY_GIVEUP`: min 1, default 3 (`lib.sh#L2613`)
- `SKS_IDLE_RETRIES`: min 0, default 2 (`lib.sh#L2683`)
- `SKS_IDLE_RETRY_BACKOFF_S`: min 0, default 10 (`lib.sh#L2684`)
- `MAM_LOCK_STEAL_RETRIES`: min 0, default 3 (`loop_lock.sh#L465`)
- `MAM_DIFF_MAX_BYTES`: min 1, default 200000 (`diff_collect.sh#L448`)
- `MAM_DIFF_MAX_LINES`: min 1, default 4000 (`diff_collect.sh#L449`)
- `RECONCILE_POLL_INTERVAL`: min 1, default 15 (`reconcile.sh#L478`)
- Preserved fractional semantics: `SKS_QUIESCENT_INTERVAL` is intentionally kept as float (default 0.5s) and documented in `NOT_ARITHMETIC`.
- Test coverage: `tests/test_issue26_ints.py` updated with all new knobs, table minimum verifications, and standalone sourcing tests (`test_b5_scripts_sourced_without_lib_sh_read_their_knobs_as_decimal`).
### 2.5. F5: Test Hook Removal from Production Code
- **Implementation**:
- Removed `if os.environ.get("MAM_TEST_UNRELIABLE_AGENT") == args.agent: reliable = False` from `lib_py/stall_watch.py#L228`.
- In `tests/test_issue30_stall_watch.py#L880-L886`, updated `_watch` to inject an `_UNRELIABLE_MAIN` wrapper that sets `type(get_adapter(...)).agent_status_reliable = property(lambda self: False)` dynamically in the test process.
- Added `test_s13_the_unreliable_case_needs_no_switch_in_the_product` (`#L918-L922`) to ensure production code contains no `MAM_TEST_` switches.
### 2.6. F6: Documentation & Test Precision
- **Implementation**:
- `multi-agent-mux-delegate-job/SKILL.md#L407-L410`: Clarified that `<= 60 s` applies to herdr wait calls, and noted that active notification publishing can extend wrapper wait time until publication completes.
- `tests/test_issue30_stall_watch_stop.py#L936-L975`: Updated `test_a_wrapper_gone_during_the_wait_gets_no_notice_and_no_nudge` with an `in_wait` hook that flips wrapper liveness strictly during the second wait (`tick == 2`), avoiding heuristic call-count assumptions.
---
## 3. Verification Test Results
Tests executed in verification path `/var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261001T230324Z-b511bf/1` with isolated basetemp:
| Test Suite | Result | Duration |
| :--- | :--- | :--- |
| `tests/test_issue26_envfile.py` | **25 passed** | ~6.5s |
| `tests/test_version_consistency.py` | **15 passed** | ~1.0s |
| `tests/test_issue26_ints.py` | **93 passed** | 37.39s |
| `tests/test_issue30_stall_watch_stop.py` | **11 passed** | ~33s |
| `tests/test_tier1_unit.py` | **67 passed** | 60.45s |
| `tests/test_issue21_acceptance.py` | **10 passed** | 38.69s |
| `tests/test_issue30_stall_watch.py` | **48 passed, 1 skipped** | 263.62s |
| Git whitespace check (`git diff base...HEAD --check`) | **Clean (0 errors)** | - |
All tests passed with zero failures and zero residual processes.
---
## 4. Conclusion
All items F1 through F6 have been implemented accurately and tested thoroughly. No out-of-scope modifications were introduced.
[VERDICT: PASS]