feat(issue-24): startup dialogs come from the agent adapter and are handled while waiting for the TUI
handle_startup_dialogs was a claude-only string ladder called only when AGENT=claude, and wait_for_tui_ready does not treat a dialog screen as ready. So agy, grok and codex sat on their directory-trust prompt for the full readiness timeout, the session was recorded as tui-ready-timeout, and onboarding injection was disabled (create_session.sh:313-314) - a human had to accept each dialog by hand. The signatures and accept keys move to the adapters as `startup_dialogs` (pattern, keys, kind), published through the existing `facts` eval contract as MAM_STARTUP_DIALOGS. claude's ladder moves over verbatim; agy takes Enter, grok y, codex Enter, and codex's update notice takes 2 (Skip), which blocks a start just as hard while changing nothing. kind is `trust` or `notice`: --no-auto-trust leaves trust dialogs to a human and still answers notices, since trusting a directory makes codex load its project-local config, hooks and exec policy. Re-sending is gated by time (MAM_DIALOG_RESEND_S, default 5s), not by frames. #24's comment reports that `--source visible` keeps showing an accepted dialog for a while, and _pane_capture hardcodes that source, so "still on screen" is not evidence the keys were missed; acceptance is judged by the ready tokens alone. Two existing tests asserted the old shape and are updated, not weakened: b19's "Escape branch stays" now looks for it in claude's adapter, and c1b's "Enter once per iteration" becomes "never twice for one frame", which the cooldown satisfies strictly more tightly. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
3bcaa39ab0
commit
5ba04a27ca
11 files changed
+344
-29
No files matched your search
@@ -24,6 +24,20 @@ class CodexAgentAdapter(BaseAgentAdapter):
|
||||
def delegate_agent_key(self) -> str:
|
||||
return 'codex-cli'
|
||||
|
||||
@property
|
||||
def startup_dialogs(self) -> list:
|
||||
# #24: the trust prompt lists "1. Yes, continue" preselected, so Enter
|
||||
# accepts. Trust here also loads this project's local config, hooks and
|
||||
# exec policy, which is why --no-auto-trust exists.
|
||||
#
|
||||
# The 0.155.1 update notice (observed 2026-09-22) blocks the session the
|
||||
# same way; "2" is Skip, the choice that changes nothing.
|
||||
return [
|
||||
('Do you trust the contents of this directory|1\\. Yes, continue',
|
||||
['Enter'], 'trust'),
|
||||
('1\\. Update now|Skip until next version', ['2'], 'notice'),
|
||||
]
|
||||
|
||||
@property
|
||||
def identity_cache_fields(self) -> tuple:
|
||||
return ('session_id',)
|
||||
|
||||
Reference in new issue
Block a user