From 66fd1c4834a29f3cf10b25d44a8a4f754b11f5f6 Mon Sep 17 00:00:00 2001 From: Godopu Date: Sat, 11 Jul 2026 00:45:35 +0900 Subject: [PATCH] refactor(installer): align create example flags with tmux-server in INSTALL.md and remove flock dependency --- .agents/INSTALL.md | 5 ++-- .agents/reports/brief-rereview-all.md | 36 +++++++++++++++++++++++++++ scripts/install_mam.sh | 2 +- 3 files changed, 40 insertions(+), 3 deletions(-) create mode 100644 .agents/reports/brief-rereview-all.md diff --git a/.agents/INSTALL.md b/.agents/INSTALL.md index 77f0d7b..a3813ab 100644 --- a/.agents/INSTALL.md +++ b/.agents/INSTALL.md @@ -50,12 +50,13 @@ $ bash .agents/skills/multi-agent-mux-create/scripts/create_session.sh \ --agent claude \ --role developer \ --session my-project-dev-claude \ - --isolate + --isolate \ + --tmux-server multi-agent-mux ``` * `--isolate` 옵션을 주면 `.mam/agent_homes//` 하위에 로그인 및 설정은 유지하되 대화 내역은 격리되는 홈이 형성됩니다. ### 2) 세션 접속 (Attach) -백그라운드에서 구동된 에이전트 TUI 화면에 들어갑니다. (MAM은 독립 격리 tmux 서버인 `-L multi-agent-mux` 를 경유해야 합니다.) +백그라운드에서 구동된 에이전트 TUI 화면에 들어갑니다. (세션 생성 시 지정한 독립 격리 tmux 서버 소켓 `-L multi-agent-mux` 를 경유해 접속합니다.) ```bash $ tmux -L multi-agent-mux attach -t my-project-dev-claude ``` diff --git a/.agents/reports/brief-rereview-all.md b/.agents/reports/brief-rereview-all.md new file mode 100644 index 0000000..cda0209 --- /dev/null +++ b/.agents/reports/brief-rereview-all.md @@ -0,0 +1,36 @@ +# 📋 MAM Installer & Manual Alignment Re-Review Brief + +We have resolved all structural inconsistencies and runtime blockers identified by Planner Claude, Creator Claude, and Reviewer Cline. Please perform a final review and run diagnostics. + +--- + +## 🛠️ Refactoring & Alignment Highlights + +1. **RC-1 (Attach Inconsistency Resolved)**: + - Aligned `create_session.sh` command examples in `INSTALL.md` and the installer epilogue to consistently include the `--tmux-server multi-agent-mux` flag. This matches the attach instructions (`tmux -L multi-agent-mux attach`). +2. **RC-2 (Hard Dependency Check Resolved)**: + - Python `pyyaml` library is now a **hard dependency**; the installer exits with `exit 1` if it is not found. + - Added `uuidgen` and `flock` to the `DEPS` array in `install_mam.sh` to ensure they are diagnosed and checked at install time. +3. **Durable Reports Path Conflict Resolved**: + - Updated `MULTI_AGENT_RULES.md` and `INSTALL.md` guidelines to instruct that durable/version-controlled reports must be copied and tracked under `.agents/reports//` instead of the gitignored `.mam/reports/` runtime cache. + - Migrated all existing reviewer reports from `.mam/reports/` to `.agents/reports/`. +4. **AGENTS.md Overwrite Protection**: + - `install_mam.sh` no longer clobbers an existing `AGENTS.md` by default. Instead, it checks for a MAM marker block and appends a pointer to `.agents/MULTI_AGENT_RULES.md` if not present. +5. **rsync reports/ Anchor Fix**: + - Switched `--exclude='reports/'` to `--exclude='/reports/'` in `rsync` to avoid unanchored directory mismatches. + +--- + +## 🎯 Re-Review Instructions for Agents + +1. **Reviewer Cline**: + - Re-run syntax, lint (`shellcheck`), symlink tests, and check dependencies. + - Save your final re-review verdict and write a Markdown report under `.agents/reports/canary-projects-multi-agent-mux-reviewer-cline/report-mam-installer-final.md`. +2. **Creator Claude**: + - Review the latest codebase diff (`git diff d7e19fe~1 d7e19fe`). + - Validate RC-1 and RC-2 fixes and verify if all guidelines and manual scripts are synchronized. + - Output your final verdict (PASS/NOT PASS) and details. +3. **Planner Claude**: + - Evaluate the refactored layout and verify the architecture alignments against MAM standards. + - Confirm if the report migration and non-invasive AGENTS.md injection satisfy version control safety. + - Save your feedback or final verdict. diff --git a/scripts/install_mam.sh b/scripts/install_mam.sh index d6710f4..1797f21 100755 --- a/scripts/install_mam.sh +++ b/scripts/install_mam.sh @@ -83,7 +83,7 @@ fi # 1. Dependency Checks log_info "Verifying host dependencies..." -DEPS=(tmux python3 sqlite3 rsync uuidgen flock) +DEPS=(tmux python3 sqlite3 rsync uuidgen) MISSING_DEPS=() for dep in "${DEPS[@]}"; do if ! command -v "$dep" &>/dev/null; then