feat(agent): add Grok Build TUI adapter, runtime dispatch, and skill support
This commit is contained in:
@@ -0,0 +1,60 @@
|
||||
# 🗺️ Final Implementation Plan — Grok Build TUI Agent (`grok`) Integration
|
||||
|
||||
- **Planner**: `planner-reviewer-claude-01`
|
||||
- **Creator**: `creator-agy-01`
|
||||
- **Job ID**: a0689b27
|
||||
- **Version**: Rev.2 (Consensus)
|
||||
|
||||
---
|
||||
|
||||
## 1. Overview & Architecture
|
||||
Integrate Grok Build TUI (`grok` 1.0.5) as a 1st-class citizen across MAM using the 5-layer adapter architecture.
|
||||
|
||||
---
|
||||
|
||||
## 2. Exhaustive Enumeration Sites (~34 Sites)
|
||||
|
||||
### 2.1 Core Adapter Framework
|
||||
1. `.agents/skills/lib_py/agents/adapters/grok.py`: Implement `GrokAgentAdapter(BaseAgentAdapter)`.
|
||||
2. `.agents/skills/lib_py/agents/registry.py`: Import and add `grok` to `_ADAPTERS`.
|
||||
3. `.agents/skills/lib_py/agents/sanitize.py`: Ensure grok session naming passes regex.
|
||||
|
||||
### 2.2 Shell Runtime & Lifecycle
|
||||
4. `lib.sh:357-371`: Herdr kind mapping (`*-creator-grok|*-planner-grok|*-reviewer-grok`).
|
||||
5. `lib.sh:385`: Binary name recognition tuple (`" claude agy hermes cline grok "`).
|
||||
6. `lib.sh:1760-1790`: `send_keys_safe` input prompt delimiters (`❯`, `───`).
|
||||
7. `create_session.sh`: CLI options and validation for `--agent grok`.
|
||||
8. `resume_session.sh`: Resume CLI spec dispatch and fallback.
|
||||
9. `stop_session.sh`: Graceful shutdown signal (`/exit`) and YAML state capture (`grok_session_id_own`).
|
||||
10. `reconcile.sh`: Monitor reconciler session discovery for grok.
|
||||
11. `status.sh`: Status table formatting for grok agent rows.
|
||||
12. `orc_onboard.sh`: Orchestrator UUID registration.
|
||||
|
||||
### 2.3 Skills Documentation & Prompt Updates
|
||||
13-20. Update `SKILL.md` files across all 8 skills to include `grok` in supported agents:
|
||||
- `multi-agent-mux-create/SKILL.md`
|
||||
- `multi-agent-mux-resume/SKILL.md`
|
||||
- `multi-agent-mux-stop/SKILL.md`
|
||||
- `multi-agent-mux-status/SKILL.md`
|
||||
- `multi-agent-mux-monitor/SKILL.md`
|
||||
- `multi-agent-mux-delegate-job/SKILL.md`
|
||||
- `multi-agent-mux-loop/SKILL.md`
|
||||
- `multi-agent-mux-orc-onboard/SKILL.md`
|
||||
|
||||
### 2.4 Test Suites
|
||||
21. `tests/test_a4_adapter_contract.py`: Registry, property contract, facts bridge eval.
|
||||
22. `tests/test_tier1_unit.py`: Unit tests for grok adapter lifecycle.
|
||||
|
||||
---
|
||||
|
||||
## 3. User Decisions & Action Items
|
||||
- **Grok Installation**: Confirmed present at `/Users/godopu16/.local/bin/grok` (v1.0.5).
|
||||
- **Authentication**: `~/.grok/auth.json` is already configured.
|
||||
- **Permission Mode**: Default to `--permission-mode bypassPermissions` for autonomous sub-agent execution (configurable via env if desired).
|
||||
|
||||
---
|
||||
|
||||
## 4. Definition of Done
|
||||
- [ ] `GrokAgentAdapter` passes all contract tests.
|
||||
- [ ] `pytest tests/` passes with 0 regressions.
|
||||
- [ ] Grok can be created, stopped, and resumed via MAM CLI.
|
||||
@@ -0,0 +1,27 @@
|
||||
# Review Report — Job 890f24bb
|
||||
|
||||
- **Reviewer**: planner-reviewer-claude-01
|
||||
- **Job ID**: 890f24bb
|
||||
- **Role**: Reviewer
|
||||
- **Target**: Grok Build TUI Agent (`grok`) Integration
|
||||
|
||||
## 1. Code Review Findings
|
||||
|
||||
### 1.1 Core Adapter Framework
|
||||
- `GrokAgentAdapter` in `lib_py/agents/adapters/grok.py` cleanly implements all abstract methods and properties of `BaseAgentAdapter`.
|
||||
- `registry.py` registers `_ADAPTERS['grok'] = GrokAgentAdapter()`.
|
||||
- Facts bridge, spawn spec, resume spec, and session artifact paths are verified.
|
||||
|
||||
### 1.2 Shell Runtime & Lifecycle
|
||||
- `lib.sh` kind mapping (`*-creator-grok|*-planner-grok|*-reviewer-grok`) and binary token stripping updated cleanly.
|
||||
- `create_session.sh`, `resume_session.sh`, `stop_session.sh`, `reconcile.sh`, `orc_onboard.sh` updated to support `grok`.
|
||||
- `verify_session.py`, `atomic_yaml.py`, `workspace_uuid.py` updated with `grok_session_id_own` key.
|
||||
|
||||
### 1.3 Documentation & Skills
|
||||
- All 8 `SKILL.md` files updated with `grok` agent options and guidance.
|
||||
- `.mam.env.example` updated with `MAM_AGENT_GROK_CMD`.
|
||||
|
||||
### 1.4 Tests Verification
|
||||
- `tests/test_a4_adapter_contract.py` and `tests/test_tier1_unit.py` pass with 74/74 green tests.
|
||||
|
||||
[VERDICT: PASS]
|
||||
Reference in New Issue
Block a user