docs(deploy): add --remove offboarding command to INSTALL.md and save review report

2026-08-12 14:37:50 +09:00
parent f9b51b3ab3
commit da92624273
2 changed files with 66 additions and 0 deletions
@@ -0,0 +1,63 @@
+# Cross-Code Review Report — Job 49465a26
+
+- **Job ID**: 49465a26
+- **Target**: `deploy/INSTALL.md` — add `--remove` (offboarding) command to the Orc-Onboard section
+- **Reviewer**: cline
+- **Context**: Fourth review of the orc-onboard changeset. The prior review (job 7fed847e) noted as a *minor non-blocking* item that the INSTALL.md Orc-Onboard section documented only `--uuid` and `--list`, omitting `--remove` (offboarding). This delta addresses exactly that note.
+- **Output Report Path**: `.mam/jobs/49465a26/cline-reports/report-final.md`
+
+---
+
+## 1. Delta Description
+
+A 3-line addition to `deploy/INSTALL.md` (uncommitted, `M deploy/INSTALL.md`), on top of the committed changeset (HEAD `f9b51b3`). No other files changed.
+
+```diff
+@@ -122,6 +122,9 @@ $ bash .agents/skills/multi-agent-mux-orc-onboard/scripts/orc_onboard.sh --uuid
+
+ # 등록된 오케스트레이터 UUID 목록 확인
+ $ bash .agents/skills/multi-agent-mux-orc-onboard/scripts/orc_onboard.sh --list
+
+# 등록된 오케스트레이터 UUID 제거 (오프보딩)
+$ bash .agents/skills/multi-agent-mux-orc-onboard/scripts/orc_onboard.sh --remove <orchestrator_uuid>
+ ```
+```
+
+The `git diff` matches the brief diff exactly. The section now documents the full onboarding lifecycle: `--uuid` (onboard) → `--list` (view) → `--remove` (offboard).
+
+---
+
+## 2. Lint
+
+Docs-only change (Markdown). No shell/Python files touched.
+
+- **Markdown structure**: The new lines are placed correctly *inside* the existing ```bash code block, after the `--list` command and before the closing fence. The code fence closes properly; the `---` horizontal rule and subsequent sections are intact. ✅
+- **Section numbering**: `### 6) 오케스트레이터 온보딩 (Orc-Onboard)` is unchanged (no renumbering needed). ✅
+- Underlying scripts (`orc_onboard.sh`, `lib.sh`) are unchanged from the committed state (prior reviews confirmed `bash -n` clean; shellcheck covered by CI via `gitea-ci.yml`).
+
+---
+
+## 3. Behavior (동작성)
+
+- **No code changed** → no behavioral impact. Confirmed: `tests/test_orc_onboard.py` → **40 passed in 6.34s** (foreground, deterministic).
+- **`--remove` flag accuracy**: verified against `orc_onboard.sh`:
+  - Usage help (line 23): `--remove <uuid>    Remove specified UUID from orchestrator_uuids list`
+  - Case handler (lines 39-43): `--remove)` requires a UUID argument (`if [ $# -lt 2 ] || [ -z "$2" ]; then usage; fi`), sets `TARGET_UUID="$2"`, `MODE="remove"`.
+  - The documented command `--remove <orchestrator_uuid>` is real and matches the actual CLI. ✅
+- **Test coverage**: `test_o13_onboard_remove_uuid` (line 252) runs `run_onboard(["--remove", orc_uuid], ...)` and verifies the UUID is removed from the registry. The documented command is behaviorally tested. ✅
+
+---
+
+## 4. Loss / Hygiene (유실)
+
+- **Single-file docs change**: only `deploy/INSTALL.md` modified; no code, no test, no config impact. No orphaning risk.
+- **No stray artifacts**: docs change produces no runtime artifacts.
+- **No regressions**: 40/40 tests pass; no code touched.
+
+---
+
+## 5. Verdict
+
+The delta is a minimal, accurate docs addition that completes the Orc-Onboard lifecycle documentation (onboard → list → offboard) in `deploy/INSTALL.md`. The documented `--remove <orchestrator_uuid>` command matches the actual `orc_onboard.sh` CLI, is placed correctly within the existing code block, and is behaviorally covered by `test_o13`. No code changed, tests remain 40/40 deterministic, and no regressions or hygiene issues exist. This resolves the minor non-blocking note from the prior review (7fed847e). No design-level rework is needed.
+
+[VERDICT: PASS]