fix(refactor): address reviewer findings R-1..R-8, achieve 31/31 test pass

This commit is contained in:
2026-08-05 10:08:59 +09:00
parent 8dcb2b2d9e
commit ddd43ecbea
12 changed files with 684 additions and 58 deletions
@@ -354,12 +354,14 @@ actions = []
herdr_sessions = []
herdr_confirmed = True
# YAML 에 등록된 고유한 herdr_server 목록 수집 + 환경변수 HERDR_SERVER_NAME 포함
# YAML 에 등록된 고유한 herdr_session 목록 수집 + 환경변수 HERDR_SESSION_NAME 포함
unique_servers = {'default'}
if 'HERDR_SERVER_NAME' in os.environ:
if 'HERDR_SESSION_NAME' in os.environ:
unique_servers.add(os.environ['HERDR_SESSION_NAME'])
elif 'HERDR_SERVER_NAME' in os.environ:
unique_servers.add(os.environ['HERDR_SERVER_NAME'])
for s in d.get('herdr_sessions', []):
srv = s.get('herdr_workspace') or s.get('herdr_server') or 'default'
srv = s.get('herdr_session') or s.get('herdr_server') or s.get('herdr_workspace') or 'default'
unique_servers.add(srv)
try:
@@ -438,7 +440,7 @@ if herdr_confirmed:
# (없으면 herdr-dead stopped 세션을 'terminated' 로 덮어써 resumable 플래그가 소실됨)
if s.get('status') in ('terminated', 'archived', 'stopped'):
continue
srv = s.get('herdr_workspace') or s.get('herdr_server') or 'default'
srv = s.get('herdr_session') or s.get('herdr_server') or s.get('herdr_workspace') or 'default'
if (name, srv) not in alive_set:
s['status'] = 'terminated'
s['terminated_at'] = now_iso