fix(issue-12,8,7): keep broker password out of records, keep fresh install stamps, pack sibling workspaces
Issue #12 - MQTT_PASSWORD was copied into every job record, which any sub-agent can read. BrokerConfig.to_registry_block no longer persists it; broker_config_from_job layers the password back from the environment (.mam.env) at connect time, so publish_event still connects from the record. _atomic_write_record scrubs broker.password from any record it writes, and `registry.py scrub-secrets [--dry-run]` migrates an existing registry. auth_token/dispatch_token stay: the agent's own publish_event needs them. Issue #8 - update.sh restored the pre-update asset_hashes.txt and version.txt over the installer's fresh ones, so version.txt named the previous commit and remove.sh backed up every pristine updated file as "locally modified". The success path now keeps the installer's stamps and only merges install_state keys the re-install did not write (gitignore_created); the failure path still restores everything verbatim. Issue #7 - the shim's new-session took the first same-cwd pane, always found the full first workspace, judged it overflow and opened another workspace per agent (4 + 1 + 1). It now walks every same-cwd workspace in pane order and takes the first with an idle pane or room in its 2xK grid; a workspace is created only when all are full (4 + 2). Tests: test_issue7_workspace_packing.py (3; the mock herdr gains an opt-in per-workspace 2x2 geometry), test_issue8_update_state.py (1, real install+update cycle), test_issue12_registry_secrets.py (4); registry CLI snapshot and help capture refreshed for the intentional scrub-secrets subcommand; registry.md documents the broker block. Refs #12 #8 #7 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCgu9Fa9iT7TbJUSzdq4Ff
This commit is contained in:
1 parent
8a09e022a6
commit
e629cc137f
12 files changed
+422
-52
No files matched your search
@@ -333,9 +333,35 @@ def _build_parser() -> argparse.ArgumentParser:
|
||||
p_logs.add_argument("--json", action="store_true",
|
||||
help="emit raw JSON lines / records instead of a table")
|
||||
|
||||
p_scrub = sub.add_parser(
|
||||
"scrub-secrets",
|
||||
help="remove broker.password from every job record (Issue #12 migration)",
|
||||
)
|
||||
p_scrub.add_argument("--dry-run", action="store_true",
|
||||
help="only list the records that still carry a password")
|
||||
|
||||
return parser
|
||||
|
||||
|
||||
def _cmd_scrub_secrets(args) -> int:
|
||||
"""Issue #12: strip broker.password from records written before
|
||||
to_registry_block stopped persisting it. Every other field is kept."""
|
||||
rd = args.registry_dir
|
||||
found = []
|
||||
with registry_lock(rd):
|
||||
for record in list(_iter_records(rd)):
|
||||
broker = record.get("broker")
|
||||
if not (isinstance(broker, dict) and "password" in broker):
|
||||
continue
|
||||
found.append(record.get("job_id", "?"))
|
||||
if not args.dry_run:
|
||||
broker.pop("password", None)
|
||||
_atomic_write_record(record["job_id"], rd, record)
|
||||
verb = "would scrub" if args.dry_run else "scrubbed"
|
||||
print(f"{verb} {len(found)} record(s) under {rd}" + (": " + ", ".join(found) if found else ""))
|
||||
return 0
|
||||
|
||||
|
||||
def _operator_write(job_id: str, registry_dir: str, **fields) -> int:
|
||||
"""Apply an operator-authority write and report a refusal on the exit status.
|
||||
|
||||
@@ -506,6 +532,9 @@ def main(argv: Optional[List[str]] = None) -> int:
|
||||
if args.command == "logs":
|
||||
return _cmd_logs(args)
|
||||
|
||||
if args.command == "scrub-secrets":
|
||||
return _cmd_scrub_secrets(args)
|
||||
|
||||
return 1
|
||||
|
||||
|
||||
|
||||
Reference in new issue
Block a user