feat(agent): deprecate and completely remove cline agent support
- Delete adapters/cline.py and unregister from registry.py - Remove cline branches from lib.sh and all 8 skill scripts (create, resume, stop, status, reconcile, update_yaml_resumed, resolve_session_id, orc_onboard) - Narrow own-key mapping dictionaries across lib_py core modules to 4 supported agents - Delete cline-exclusive tests and retarget shared fixtures to grok/hermes/claude - Update skills documentation and installation guides (439 passed, 0 failures) - Archive cline deprecation consensus and review reports
This commit is contained in:
@@ -0,0 +1,48 @@
|
||||
# 📋 Code Review Report — Complete Removal of cline Agent Support (Job 2562f9c9)
|
||||
|
||||
- **Reviewer**: `reviewer-hermes-01` (role: reviewer)
|
||||
- **Reviewed diff**: 31 files, +135/−411 — full cline removal per the GM's REMOVE decision, executed against `.agents/reports/cline_deprecation_opinion.md` §5 blast radius and plan `.agents/reports/planner-reviewer-claude-01/plan-264c3b5d.md` (Rev.2)
|
||||
- **Baseline for comparison**: merged HEAD `e0c0c10` (hermes modernization, previously reviewed by me in jobs b45fb1d4/ca4539e8)
|
||||
- **Method**: full-diff read; framework-wide residual `grep -i cline` over `.agents/skills/`, `tests/`, `deploy/`, `docs/`; syntax checks on all 10 modified shell scripts + 11 Python files; test-count delta analysis; full suite execution. No code modified by this review.
|
||||
|
||||
---
|
||||
|
||||
## 1. Verification Evidence
|
||||
|
||||
| # | Check | Result |
|
||||
|---|---|---|
|
||||
| 1 | **Full test suite** | ✅ **439 passed, 0 failures** (607.5 s) |
|
||||
| 2 | **Test-count sanity** (plan §8 requirement) | ✅ 441 → **439** collected (−2 = exactly the two cline-only tests `test_o31_cline_node_launcher_id_format` and `test_o39_cline_orchestrator_exclusion` deleted per plan §5; all other retargeted tests preserved as renamed/redirected cases). Matches plan's "decreased by roughly the number deleted, not increased or unchanged" gate. |
|
||||
| 3 | **Residual cline references** | ✅ **Zero** matches for `-i 'cline'` across `.agents/skills/`, `tests/`, `deploy/`, `docs/` (all file types) — the removal is total in live surface. (`.agents/reports/**` history correctly untouched per plan §6/§8 preservation constraint.) |
|
||||
| 4 | **Syntax**: `bash -n` on all 10 modified/affected shell scripts; `py_compile` on registry/atomic_yaml/verify_session/workspace_uuid + 6 test files | ✅ all clean |
|
||||
| 5 | Adapter + registry | ✅ `cline.py` deleted; `registry.py` no longer imports/registers it |
|
||||
| 6 | 4 `lib_py` core modules | ✅ own-key tuples/dicts reduced to 4 agents in `atomic_yaml.py`, `verify_session.py`, `workspace_uuid.py` |
|
||||
| 7 | `lib.sh` 5 mechanisms | ✅ kind mapping case + 2 grep fallbacks removed; binary-strip tuple → 4-agent; comment `~/.cline` dropped; `send_keys_safe` case arm removed; **paste-skip list retains claude/agy/grok membership** (mechanism preserved per plan §3); whitespace-normalization comment de-attributed from cline but **mechanism kept** |
|
||||
| 8 | 9 skill scripts | ✅ all cline branches/cases/tuples removed exactly per plan §4 — spot-verified against the plan's line list: create (auth gate L122–125, CMD_FULL L189, spawn dispatch L210, delegate_agent L319, child-PID L339, YAML entry L423), resume (RESOLVED_BIN branch L89–91 collapsed correctly to a single `command -v` block), stop (own-id capture L291–292), status (artifact check L93–96), reconcile (drift-C block L785–828 fully deleted, `id_name` tuple → `agent == 'claude'` per plan's style recommendation), orc_onboard (`cline_re` + argv parsing arm + env var + own-key list), run_loop (elif branch), update_yaml_resumed (PID capture + elif branch) |
|
||||
| 9 | Docs | ✅ 5 SKILL.md/README + `deploy/INSTALL.md` + `implementation_plan.md` + `docs/NEW_AGENT_INTEGRATION_GUIDE.md` (all 5 hardcoded sample sites fixed: diagram, `_ADAPTERS` dict, kind mapping, binary tuple, test-assertion sample) |
|
||||
| 10 | Test retargeting fidelity (the plan's core preservation principle) | ✅ verified concretely: `test_c3` now uses a test-local `mock_py` facts-bridge shim with genuinely differentiated strong/weak tokens ('MockApp' vs 'Use arrow keys') and `wait_for_tui_ready dummy-sess mocktiered` — this keeps the **real bridge call** in the loop exactly as the plan's Rev.2 challenge-fix required (not raw env-var injection, which would have bypassed the `[ -z … ]` gate); `test_c8b` retargeted end-to-end to claude's real modal (`Try the new fullscreen renderer?`) with a claude session name, preserving the session-name→facts→modal→RC=2 path; `test_o32` **strengthened** (cline-format IDs now asserted rejected: `"1785635248957_fajon"` added to the bad-list — correct since `cline_re` is gone); 2-tier round-trip assertions added to the facts-bridge contract test (`STRONG=`/`WEAK=` for all 4 remaining agents) |
|
||||
| 11 | Unrelated-regression check on shared logic | ✅ `send_keys_safe`'s marker/paste/submit flow, `wait_for_tui_ready`'s tier decision logic, and `verify_session_uuid` are structurally untouched apart from cline membership removal |
|
||||
|
||||
## 2. Deviations from the plan (all assessed as acceptable or improvements)
|
||||
|
||||
1. **`stop_session.sh` usage() lost two lines not required by the plan** ("Stop is always graceful and always captures the conversation id. / (idempotent: …)"). These lines were *true before and after* this change — their deletion is unrelated to cline removal. It is a small drive-by docs deletion; content is still true and was mildly useful. Low-impact; flag for the committer to either restore the two lines or confirm intentional.
|
||||
2. **`tests/test_o2_race_free_lock.py::acquire_bg` reworked** (fixed 0.3 s sleep → marker-file polling loop up to 2 s). Nothing to do with cline — this is a test-flakiness fix for a race between lock acquisition and the test's first assertion. Reasonable hardening, but it is an unrelated change riding in a cline-removal diff; it *is* defensible under "keep the suite green while removing cline" if the old timing proved flaky during this work (plausible — the lock script changed nothing, but sandbox timing may have). No action required; noted for change-transparency.
|
||||
3. **`implementation_plan.md` team line** (`cline` → `hermes`, `grok`) and **`deploy/INSTALL.md`** agent list edits: the plan said "spot-check, don't blanket-edit" these docs for *actively misleading* mentions — an agent-listing that includes a now-removed agent qualifies as actively misleading, so these edits fall inside the plan's exception clause. Acceptable.
|
||||
4. **`test_a4_adapter_contract.py` gained new assertions** (2-tier default contract, STRONG/WEAK facts-bridge round-trip) — these implement plan §5's Rev.2 addition; verified present and passing.
|
||||
|
||||
## 3. Non-blocking observations
|
||||
|
||||
1. **[Low — pre-existing, now moot for cline]** The claude drift-C block's missing sibling-exclusion (the Rev.3 consensus §6.1 item) is **not** addressed here — correctly, since the plan explicitly scoped it out as orthogonal to cline removal. It remains the one open modernization gap; recommend it be tracked as its own follow-up job rather than silently absorbed.
|
||||
2. **[Info]** `docs/NEW_AGENT_INTEGRATION_GUIDE.md`'s ASCII diagram edit preserves alignment acceptably; no rendering breakage observed.
|
||||
3. **[Info]** `test_tier2_component.py` usage-text loops now assert `grok` instead of `cline` — consistent with the scripts' actual usage() output (verified by the passing suite).
|
||||
4. **[Info]** The consensus/plan/report artifacts (`clline_deprecation_opinion.md`, plan-264c3b5d, plan-a33a133e, report-073e27d4, report-d1fe1a99, report-2e6f01f4) are included in the diff as new tracked files under `.agents/reports/` — consistent with the durable-promotion convention in `MULTI_AGENT_RULES.md` §4.
|
||||
|
||||
## 4. Risk Assessment
|
||||
|
||||
The three plan-flagged risk items are all addressed: (a) the reconcile.sh drift-C block deletion's boundaries were verified against live code (block fully gone, adjacent hermes block intact, `result = {` assembly intact); (b) orc_onboard's ancestor-walk mechanism was kept generically with only cline's case arm removed (plan §4 recommendation followed); (c) the test-count sanity check passes exactly. The suite's 439/439 green plus zero residual references means no cline path remains reachable, and the other four agents' coverage is demonstrably unchanged in structure.
|
||||
|
||||
## 5. Verdict
|
||||
|
||||
The removal is complete, surgical, and matches the planned blast radius with only two minor unrelated edits (stop_session.sh usage lines, o2 flakiness fix) that are individually defensible but worth the committer's awareness. All preservation constraints from the consensus doc §5 were honored: generic mechanisms (whitespace-normalized paste matching, paste-skip list, `_pane_quiescent`, 2-tier readiness, modal contracts) retained; generic-mechanism tests retargeted rather than deleted, with the facts-bridge genuinely still exercised; historical `.agents/reports/**` untouched.
|
||||
|
||||
[VERDICT: PASS]
|
||||
@@ -0,0 +1,43 @@
|
||||
# 📋 Code Review Report — cline Deprecation Consensus Opinion Rev.3 (Job 2e6f01f4)
|
||||
|
||||
- **Reviewer**: `reviewer-hermes-01` (role: reviewer) — participant in the reviewed consensus (job `57f33eff`) and author of the prior NOT PASS review (job `bc68ed65`); this review judges only whether Rev.3 faithfully and accurately incorporates the two review rounds.
|
||||
- **Reviewed diff**: one file — `.agents/reports/cline_deprecation_opinion.md` (Rev.2 → Rev.3, 105 → 109 lines; blob `f818c6e` → `229ad1e`, hash verified against working tree). No code changes.
|
||||
- **Context**: my previous review (job `bc68ed65`) issued `[VERDICT: NOT PASS]` with two blocking factual defects; grok's review (job `0a056794`) raised its own points. This revision claims to fix both (F1, F2) plus an attribution refinement (F3).
|
||||
|
||||
---
|
||||
|
||||
## 1. Prior Blocking Defects — Correction Verification
|
||||
|
||||
### 1.1 F1 — flag inventory (my bc68ed65 §2.2) → **FIXED, accurately**
|
||||
Rev.3 §3.2 now states: `cline --help` shows `--auto-approve <boolean>` (default true) **and** `-k, --key <api-key>` for startup key injection, bounding its scope explicitly — "cannot refresh an expired credential mid-task nor suppress the interactive TUI fallback"; and confirms no `--headless`/`--non-interactive` flag exists. §6.2's parenthetical is updated consistently ("-k, --key only provides startup key override").
|
||||
My re-verification against the live CLI (v3.0.60): `--auto-approve` default true ✅; `-k, --key <api-key>` present ✅; no `--headless`/`--non-interactive` ✅. The corrected scoping is exactly the right technical characterization — it neither overstates nor understates what `-k` buys.
|
||||
|
||||
### 1.2 F2 — drift-C modernization status (my other blocking defect) → **FIXED, accurately**
|
||||
§2 point 3 and §6.1 now state: sibling-exclusion + epoch discipline exist only in **agy (~692)** and **hermes (~742)**; **claude (~637)** and **cline (~785)** both lack it, and §6.1's urgent fix now covers **both** cline and claude blocks.
|
||||
Line references re-verified against live code: block markers at 637/676/725/785; `sibling_claimed` present only at 692 (agy) and 742 (hermes) — claude's block (637–665) verifies against raw `s`. All four line numbers in the document are correct. The omission that made Rev.2 not-passable is fully remediated.
|
||||
|
||||
### 1.3 F3 — consensus attribution (grok's review) → **FIXED**
|
||||
§2.3/§6.1 now attribute positions correctly (Hermes: RETAIN-condition; Planner: urgent; Grok: delete-if-REMOVE). Grok's review job `0a056794` exists with the expected brief, and its original report (e0916903) indeed recommends REMOVE as summarized in §1's table.
|
||||
|
||||
## 2. Carry-Over Claims — Re-verified (no regression between Rev.2 → Rev.3)
|
||||
|
||||
| Claim | Status |
|
||||
|---|---|
|
||||
| §3.1 modal-check scope (spawn + injection-time only, never continuous) — lib.sh `_pane_dialog_open` consumers | ✅ re-confirmed (wait_for_tui_ready:1888, send_keys_safe:2081 are the only consumers) |
|
||||
| §3.3 / §2.4: 40 standalone sessions, oldest `1782614591159_mrkxj` | ✅ re-confirmed live |
|
||||
| §2.2: only claude.py + cline.py override `modal_tokens` | ✅ |
|
||||
| §2.6 / §5: blast-radius enumeration (incl. 5-tuple whitelist assertion in test_tier1_unit.py:963, fixture names) | ✅ re-confirmed |
|
||||
| §2.5 / §5: cline timestamp IDs, orc_onboard regex `^[0-9]{10,}_[0-9A-Za-z]+$` (L69–70), argv0-aware ancestor walk + cline argv parsing (`--id`/`--session-id`, orc_onboard.sh:128–129), per-family env vars (L147) | ✅ all confirmed — the §5 "node-as-argv0 ancestor-walk accommodation" claim is accurate: `detect_nearest_agent` (orc_onboard.sh:76–164) walks ancestors via `ps -o command=`, basename-matches agent tokens, and parses cline's `--id` from the command line; `test_o31_cline_node_launcher_id_format` (exec -a argv0 rewrite) covers exactly this |
|
||||
| §4 honest 2–1 split; final decision deferred to GM | ✅ preserved in Rev.3 |
|
||||
|
||||
## 3. Residual Findings (non-blocking)
|
||||
|
||||
1. **[Info — nuance, no doc change required]** claude's epoch story differs in kind from cline's: `claude.py::verify_artifact` still uses a file-level `getmtime` check (claude.py:54), but each claude session is one `.jsonl` file, so file-mtime **is** row-level there — unlike hermes's shared `state.db`, which is why hermes needed the row-level rewrite and claude does not. Rev.3's §6.1 correctly treats claude and cline as equally *structurally* un-modernized (both lack sibling exclusion in reconcile.sh); readers should note the adapter-level epoch mechanics differ (claude's per-file mtime is adequate; cline's per-file mtime likewise). This nuance does not change §6.1's operative instruction.
|
||||
2. **[Info]** §6.2's `MULTI_AGENT_RULES.md` capability-restriction remains a protocol-document change requiring GM + Team Leader consent per that document's own amendment clause — correctly framed as a recommendation, not an enacted rule.
|
||||
3. **[Info]** No lint issues (markdown-only diff).
|
||||
|
||||
## 4. Assessment
|
||||
|
||||
Both blocking defects from job `bc68ed65` are corrected faithfully — not merely acknowledged, but with correct line-level references and properly bounded flag semantics. The F3 attribution addition (grok's REMOVE-side framing of the drift block as deletable debt) is a genuine improvement in consensus fidelity. All checkable claims now survive direct verification against the live repo, live CLI, and live environment. The document maintains its honest 2–1 split presentation and correct GM deferral.
|
||||
|
||||
[VERDICT: PASS]
|
||||
Reference in New Issue
Block a user