GodopuandClaude Opus 5.5
e3bcdee834
Review loop (--review-only, --all-reviewer, fact-checked against the code): rounds 1-3 NOT PASS with factual corrections, round 4 (@62da805) 4/4 PASS. Documentation only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCgu9Fa9iT7TbJUSzdq4Ff
1.8 KiB
Review 2311b972 — test share and generate-env.sh
Head 62da8056680fca939a2aff924037ed48b5f74afa (tree f549246ffbe2d5e58cb7e33c212a383cd429dce5) is the one commit 62da805 docs(readme): round-3 review fixes (21063f28) on base ae2813773c973daedd2275cb55ad340a682c3fae. Two files, README.md and README.ko.md, two lines each, +4/−4. git diff --check is clean. Snapshot porcelain empty. Control-plane main is still 2ccf43911cda78fd0655c3770eec90cd22ec2d1b, porcelain empty.
The two sentences match
README.md:175 says every test gets a temporary job registry and audit-log directory, about a third also use the sandbox fixtures that set a temporary HOME, and fewer of those use a mock herdr. That is the count from the previous review of this same test tree: weighting the parametrize lists written out in the source, 573 of 1708 (34%) reach a temporary HOME and 196 of 1708 (11%) reach mock_herdr. The autouse fixture still points every test's registry and audit log at a temporary directory (tests/conftest.py:170-186). README.ko.md:175 says the same fraction and the same split.
README.md:41 says deploy/generate-env.sh creates .mam.env from .mam.env.example when .mam.env is missing, and that --force overwrites it while keeping a .mam.env.bak. The script copies the example when the destination is absent (deploy/generate-env.sh:54-64). When the destination exists and --force is absent, it exits 0 without writing (:54-57). With --force and an existing file, it copies that file to $DST.bak, which is .mam.env.bak, and then copies the example over it (:59-64). README.ko.md:41 says the same.
The script was not executed. No herdr server was started. The suite was not run.
User ~/.config/herdr/config.toml mtime stayed 1784456394.
[VERDICT: PASS]