Godopu
47640e2fd7
- R1: use herdr send-keys C-c for graceful stop - R2: preserve JSONL fallback discovery when database is empty - R3: apply workspace-scoped SQLite query before bounding results - R4: tighten artifact validation to fail closed on missing/invalid metadata - R5: verify actual rollout presence before reporting resumable in status - R6: remove unconditional drift-B backend command fallback - T1: parameterize artifact metadata regression with verified finder fixture - T2: seed unmanaged and managed sessions in mock herdr for drift-B testing - Add final loop review reports (100% PASS)
3.9 KiB
Follow-up review — ca31d443
Reviewed the cumulative corrections on support-codex, HEAD 76f10b2, with particular attention to T1 and T2 from job ff721ed1. Both remaining findings are resolved. No new blocking findings were identified in this review. No production files were edited by this reviewer.
Findings closed
T1: Invalid-metadata regression now exercises the verifier
The test installs the rollout finder override before every invalid case and explicitly verifies that the fixture resolves and exists. It covers missing identity/workspace metadata, mismatched identity/workspace, malformed JSON and payload types, database/transcript cwd disagreement, and a valid database/transcript control case. Pytest monkeypatch restores the singleton adapter after the test.
Independent mutation verification: loaded CodexAgentAdapter.verify_artifact from 76f10b2 and bound it to the registry adapter in memory, then ran the revised test in a temporary directory. The test correctly failed with Expected False for payload: {}. The same revised test passes with the current implementation. This directly closes the previous false-positive regression coverage.
T2: Unmanaged-session regression now reaches drift-B
The revised test uses the existing mock Herdr fixture, seeds both unmanaged and managed agent records, asserts listing and pane metadata visibility, and checks both emitted drifts and resulting YAML. The managed positive control must register while the unmanaged session must remain absent.
Independent mutation verification: instantiated the actual sandbox and mock Herdr fixtures in a temporary directory, restored only that sandbox's reconcile script to 76f10b2, and ran the revised test. It correctly failed at tests/test_tier1_unit.py:1236: assert not any(d.get("name") == unmanaged_name for d in drifts). This confirms failure occurs at the intended unmanaged-session behavior, rather than during setup or visibility checks. The test passes with the current reconciler.
Prior production findings
The four production correction files have the same Git blob hashes as in the prior review:
- Codex adapter:
1e7a5c74f968f56521108b95a707fbe07768a07e - Reconciler:
da806b7237e21ee55b9e1b5ea7bec1c72d570f79 - Status:
d668bbdea0704ea6ddd5c33b3ddba3a8184b0f48 - Stop:
d14ffeb7208caa299737cafc268cc338ff4addd6
Accordingly, the prior acceptance of R1–R6 stands: control-key stop transport, empty/stale DB fallback, workspace-scoped discovery, metadata validation, stale-row status handling, and managed-session identification. T1/T2 now provide effective regression protection for the two previously uncovered cases.
Validation
Current run:
./.venv/bin/python -m pytest tests/test_a4_adapter_contract.py tests/test_tier1_unit.py::test_reconcile_drift_b_unmanaged_session_ignored tests/test_version_consistency.py -q
Result: 36 passed in 10.71 seconds, exit 0.
- Both independent old-code mutation checks failed at the intended defect assertions, as detailed above.
git diff --check main: clean.- Inspection confirmed the remaining cumulative changes match the previously reviewed fixes, with the two regression-test corrections described above.
Validation scope: the prior follow-up independently passed 43 focused adapter/lifecycle/status/version tests on the same production fixes. The initial review independently passed all 462 baseline tests on 76f10b2. Those are historical results, not a claim that this review reran the full suite on the current working tree. This round reran the affected adapter tests, corrected reconciler test, and version checks; only the regression tests changed since the prior accepted production fixes.
Disposition
T1 and T2 are closed; all findings raised by this reviewer are resolved. No planner escalation is needed. This verdict covers the reviewed working-tree changes and does not itself merge or commit them.
[VERDICT: PASS]