GodopuandClaude Opus 5.5
f19f94099f
With the cwd premise fixed, test_b still failed on herdr 0.9.3: a pane whose
saved directory is gone is restored as a placeholder - `restore_error`
"Saved directory is unavailable...", no process - and `pane process-info`
answers pane_not_found. close_restored_shells raised on it and exited 1
before looking at the other panes, so the resumed session's removed-worktree
pane (the case #45 closes on herdr 0.9.1, where it is a shell in $HOME) was
left behind.
Such a pane has nothing running, so it now meets condition 4. Only that
exact answer counts - restore_error set AND pane_not_found; any other
process-info failure still stops the run with exit 1 as before.
Tests: test_issue45_restore.py passes on herdr 0.9.3 (5/5). Unit tests with a
stub herdr: the placeholder is closed (fails at 56d0bfd); pane_not_found
without restore_error, or restore_error with another error, still raises.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HCGpJXhSZasJLU38ksDghe
111 lines
4.7 KiB
Python
111 lines
4.7 KiB
Python
"""Issue #45 (B): close the restored empty shells of the session being resumed.
|
|
|
|
With restore-on-restart off (lib_py/herdr_config.py) a restarted MAM server
|
|
still brings every saved pane back - as an empty shell in its old cwd. When
|
|
that directory is gone, herdr 0.9.1 opens the shell in $HOME and herdr 0.9.3
|
|
keeps the old path with no shell in it (see 4.); nothing below looks at the
|
|
cwd. A pane keeps the
|
|
`agent_session` its agent
|
|
reported before the server died. resume_session.sh calls this once, right
|
|
before it spawns, with the id it is about to resume; a pane is closed only when
|
|
all of these hold:
|
|
|
|
1. the target is an isolated MAM server (HERDR_SESSION_NAME set, not default);
|
|
2. herdr sees no live agent in it;
|
|
3. its agent_session value is that id - so a user's pane, another session's
|
|
pane and a freshly split pane (no agent_session yet) are never candidates;
|
|
4. its foreground process is the shell itself (nothing running in it) - or
|
|
it has no process at all: herdr 0.9.3 restores a pane whose directory is
|
|
gone as a placeholder (`restore_error` set) that `pane process-info`
|
|
reports as pane_not_found.
|
|
|
|
The registry is not consulted: a session whose server died stays `running`
|
|
there, so "running" cannot tell a live pane from a restored one.
|
|
|
|
CLI: `python3 -m lib_py.herdr_restore close-restored-shells --session-id ID
|
|
[--herdr PATH]`. One stderr line per closed pane; exit 1 when herdr cannot be
|
|
queried (the caller only warns).
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import argparse
|
|
import json
|
|
import os
|
|
import subprocess
|
|
import sys
|
|
from typing import List, Optional
|
|
|
|
# A pane exports these; they would point the query at the caller's own server
|
|
# and workspace instead of the --session named here.
|
|
_SCOPE_ENV = ("HERDR_WORKSPACE_ID", "HERDR_PANE_ID", "HERDR_TAB_ID", "HERDR_SOCKET_PATH")
|
|
|
|
|
|
def _herdr(herdr: str, session: str, *args: str) -> dict:
|
|
env = {k: v for k, v in os.environ.items() if k not in _SCOPE_ENV}
|
|
out = subprocess.run([herdr, "--session", session, *args], env=env,
|
|
capture_output=True, text=True, timeout=30, check=True).stdout
|
|
return json.loads(out).get("result") or {}
|
|
|
|
|
|
def _shell_in_foreground(herdr: str, session: str, pane_id: str) -> bool:
|
|
info = _herdr(herdr, session, "pane", "process-info", "--pane", pane_id).get("process_info") or {}
|
|
shell, fg = info.get("shell_pid"), info.get("foreground_process_group_id")
|
|
# Only a real pid proves anything (review R2): None, 0, -1, False, "" or a
|
|
# string must leave the pane alone, however they compare.
|
|
return _is_pid(shell) and _is_pid(fg) and fg == shell
|
|
|
|
|
|
def _nothing_running(herdr: str, session: str, pane: dict) -> bool:
|
|
try:
|
|
return _shell_in_foreground(herdr, session, pane["pane_id"])
|
|
except subprocess.CalledProcessError as e:
|
|
# Only herdr's own placeholder counts: any other failure still stops the run.
|
|
if pane.get("restore_error") and "pane_not_found" in (e.stderr or "") + (e.stdout or ""):
|
|
return True
|
|
raise
|
|
|
|
|
|
def _is_pid(v) -> bool:
|
|
return isinstance(v, int) and not isinstance(v, bool) and v > 0
|
|
|
|
|
|
def close_restored_shells(session_id: str, herdr: str = "herdr",
|
|
session: Optional[str] = None) -> List[str]:
|
|
"""Close the matching panes; return their ids."""
|
|
session = os.environ.get("HERDR_SESSION_NAME", "") if session is None else session
|
|
if not session_id or session in ("", "default"):
|
|
return []
|
|
closed = []
|
|
for p in _herdr(herdr, session, "pane", "list").get("panes") or []:
|
|
pane_id = p.get("pane_id")
|
|
if not pane_id or p.get("agent"):
|
|
continue
|
|
if (p.get("agent_session") or {}).get("value") != session_id:
|
|
continue
|
|
if not _nothing_running(herdr, session, p):
|
|
continue
|
|
_herdr(herdr, session, "pane", "close", pane_id)
|
|
print(f"closed restored pane {pane_id} (cwd={p.get('cwd', '')}, agent_session={session_id})",
|
|
file=sys.stderr)
|
|
closed.append(pane_id)
|
|
return closed
|
|
|
|
|
|
def main(argv=None) -> int:
|
|
p = argparse.ArgumentParser(description="close a resumed session's restored empty shells (Issue #45)")
|
|
sub = p.add_subparsers(dest="cmd", required=True)
|
|
c = sub.add_parser("close-restored-shells")
|
|
c.add_argument("--session-id", required=True)
|
|
c.add_argument("--herdr", default="", help="the real herdr binary (not the MAM shim)")
|
|
args = p.parse_args(argv)
|
|
try:
|
|
close_restored_shells(args.session_id, args.herdr or "herdr")
|
|
except (OSError, subprocess.SubprocessError, ValueError) as e:
|
|
print(f"close-restored-shells: {e}", file=sys.stderr)
|
|
return 1
|
|
return 0
|
|
|
|
|
|
if __name__ == "__main__":
|
|
sys.exit(main())
|