multi-agent-mux/.agents/reports/planner-reviewer-codex-01/report-12669b52.md

Reviewer report — PR #69 / Issue #63

Reviewed the required snapshot at /var/folders/q_/68sxgw3j073dgjg8wl9s08vw0000gn/T/mam-review/loop-20261023T035928Z-2ccc02/1, head 1614af5b673d7519d3a38f63e3636055592b4f14, against base dc886ecd6b38c01032a55a2d1c230c73362ae630. The snapshot matches the expected tree f1af6fdd548ee5d6f6b81e2202833edfaca98188 and is clean. I read Issue #63 and PR #69. The latest delta is limited to id_order.py and its regression tests.

Previously blocking finding is closed

At the previous head (7cac6f6), _read_and_prune_markers dropped a dead-owner marker when its session name matched the caller, without checking herdr. The new code removes that exception: .agents/skills/lib_py/agents/id_order.py:219-230 now keeps a dead-owner marker until its row is registered for that attempt or herdr returns an authoritative False; live and unknown answers both retain the orphan. blockers() includes a marker without a row even when its name is the caller's (id_order.py:145-148), so a retry is refused rather than replacing its marker.

The tests now cover same-name retries with a live owner, a dead owner and live herdr session, unknown herdr state, and a confirmed-gone session (tests/test_issue63_same_cwd_ids.py:1117-1148). The real-probe integration test also retries using the orphan's own name and checks that the marker is retained (tests/test_issue63_same_cwd_ids.py:1287-1290) and then safely replaced once the session is confirmed gone (1312-1315). The test fixture uses a mocked herdr and in-process probes; it does not contact a real herdr server.

Verification

• PYTHONDONTWRITEBYTECODE=1 .../python -m pytest -p no:cacheprovider --basetemp=/tmp/mam-review-12669b52 tests/test_issue63_same_cwd_ids.py — 27 passed on macOS, Python 3.9.6 (230.59 s). This includes the orphan liveness, unknown-result, zero-wait-cap, and same-name retry cases.
• Changed shell scripts checked with /bin/bash -n — passed.
• git diff --check dc886ecd6b38c01032a55a2d1c230c73362ae630..HEAD — passed.
• The earlier review covered the broader unchanged stop/purge/resume implementation and adjacent compatibility checks. This re-review did not repeat the base checkout or all adjacent test groups because the new delta is confined to dead-owner marker pruning and its regression tests.
• No real agent-home databases or real herdr sessions were accessed.

The latest change fixes the remaining blocking same-name orphan path. The earlier probe-failure and wait-cap fixes remain covered by the passing Issue #63 tests. I found no blocking issue in this revision.

[VERDICT: PASS]