2.7 KiB
2.7 KiB
Cross-review: Issue #3 version-update assessment (v4.1.3 PATCH)
- Reviewer:
reviewer-creator-grok-01 - Job:
ec2e02e2 - Target:
.agents/reports/creator-agy-01/version-update-assessment.md(job6c24ddd0) - Method: independent SemVer read from
git log 0644e77..HEAD, livelib.sh/VERSIONS.md/resume_session.sh, not the assessment at face value.
Independent SemVer recommendation
Bump is required. Target: v4.1.3 (PATCH). Same conclusion as the assessment.
| Check | Evidence |
|---|---|
| Current release | 0644e77 shipped MAM_VERSION="4.1.2". Issue #3 code is after that tag (c49ee3b, 7e15081). Shipping those commits still labeled 4.1.2 would misidentify the release. |
c49ee3b |
Shim daemon spawn: nohup&disown → Popen(..., start_new_session=True). No CLI/YAML/--agent change. |
7e15081 |
Class A empty-UUID resume: RC=1 → spawn-spec fallback; optional --cmd-full; epoch reset. Class B verify_session.py:99-101 and test_t8 untouched. |
| MAJOR §8 | No removed flags, no removed --agent values, no YAML key deletions. Class B still hard-exits when truly unresolvable (test_t15). |
| MINOR §7 | No new agent/skill/command. Optional --cmd-full on update_yaml_resumed.sh is an internal helper, additive. Class A success-on-empty-UUID is a bugfix of a documented recovery hole, not a new subsystem (unlike v4.1.0 OpenCode). |
| PATCH §6 | Matches v4.1.1 / v4.1.2 reliability PATCH precedent. |
This reviewer’s vote: v4.1.3 PATCH. Not 4.2.0. Not 5.0.0. Do not leave 4.1.2 on the Issue #3 commits.
Assessment accuracy
The §3 table (MAJOR/MINOR/PATCH) and §5 changelog draft match the live diffs. Lockstep inventory (8 SKILL.md frontmatters, VERSIONS.md header + line 21 prose + 8-row matrix + new changelog, test_version_consistency.py) is the right edit surface. Deferring the actual bump until consensus is correct for this job’s “do not mutate version files” constraint.
Nits (do not flip the class)
lib.shis line 32, not 16. §4.1 cites#L16. Line 16 is header commentary;MAM_VERSION="4.1.2"is line 32. Packaging must edit 32 (same class of gotcha as VERSIONS.md line-21/24 prose).- Resume
SKILL.mdbody still says empty UUID →multi-agent-mux-create(line 55).resume_session.shnow succeeds for Class A. Add that doc update to the packaging checklist (frontmatter-only lockstep will not catch it). - Range
0644e77..HEADalso contains50a9f32(v4.1.2 report archive); omitted from the commit list. Harmless. - 455 tests: not re-run in this job. Prior Issue #3 targeted run was 20 passed. Do not treat 455 as independently verified here.
No [ESCALATE: PLANNER].
[VERDICT: PASS]