Review loop (--review-only, --all-reviewer, focused on this Mac: macOS, /usr/bin/python3 3.9.6, bash 3.2): round 1 (@6f4f40a) agy and grok PASS, claude and codex NOT PASS (a non-uuid id `memory` purged the auto-memory dir, a linked dir below a root was followed, a NaN startedAt counted as dead), sent as a PR comment and fixed by the author in eleven commits; round 2 (@2a8d738) confirmed all three fixed but 4/4 NOT PASS on one test holder (`sh -c "sleep 120" <uuid>` loses the uuid on macOS /bin/sh), fixed in de6f3fc; round 3 (@de6f3fc) 4/4 PASS. Full suite on macOS / Python 3.9.6 @de6f3fc: 1934 passed, 56 skipped, 1 error (the known #55 false positive: agy conversations of another workspace). The real ~/.claude, /private/tmp/claude-<uid> and herdr panes unchanged. Also names lib_py.delegation.logroot in eager.CORE_MODULES (the v4.9.4 review's non-blocking note). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCgu9Fa9iT7TbJUSzdq4Ff
127 lines
3.4 KiB
Python
127 lines
3.4 KiB
Python
"""Eager module loading for immutable runtime immunity (Issue #5 Phase 4).
|
|
|
|
Ensures all dependencies (loop, delegation, agents, external packages)
|
|
are loaded into sys.modules at loop startup, preventing mid-flight disk
|
|
modifications from triggering lazy-import syntax/EOF errors (B-13).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import importlib
|
|
import os
|
|
import sys
|
|
from typing import List, Sequence
|
|
|
|
# Framework version locked with framework constants
|
|
FRAMEWORK_VERSION = "4.9.5"
|
|
|
|
CORE_MODULES: Sequence[str] = (
|
|
# Standard library modules
|
|
"atexit",
|
|
"argparse",
|
|
"copy",
|
|
"glob",
|
|
"hashlib",
|
|
"json",
|
|
"os",
|
|
"pathlib",
|
|
"re",
|
|
"shutil",
|
|
"signal",
|
|
"sqlite3",
|
|
"subprocess",
|
|
"sys",
|
|
"tempfile",
|
|
"time",
|
|
"typing",
|
|
# Framework loop modules
|
|
"lib_py.loop.parser",
|
|
"lib_py.loop.checkpoint",
|
|
"lib_py.loop.runner",
|
|
"lib_py.loop.attribution",
|
|
"lib_py.loop.autocomplete",
|
|
"lib_py.loop.evidence",
|
|
"lib_py.loop.policy",
|
|
"lib_py.loop.shadow",
|
|
"lib_py.loop.store",
|
|
"lib_py.loop.watcher",
|
|
# Delegation and common modules
|
|
"lib_py.ints",
|
|
"lib_py.paths",
|
|
"lib_py.state",
|
|
"lib_py.atomic_yaml",
|
|
"lib_py.workspace_uuid",
|
|
"lib_py.verify_session",
|
|
"lib_py.layout",
|
|
"lib_py.delegation.engine",
|
|
"lib_py.delegation.finalize",
|
|
"lib_py.delegation.job_subscriber",
|
|
"lib_py.delegation.logroot",
|
|
"lib_py.delegation.mqtt_common",
|
|
"lib_py.delegation.notifier",
|
|
"lib_py.delegation.publish_event",
|
|
"lib_py.delegation.publisher",
|
|
"lib_py.delegation.registry",
|
|
"lib_py.delegation.service",
|
|
"lib_py.delegation.cli",
|
|
# Agent adapter registry
|
|
"lib_py.agents.base",
|
|
"lib_py.agents.registry",
|
|
"lib_py.agents.input_region",
|
|
"lib_py.agents.sanitize",
|
|
)
|
|
|
|
OPTIONAL_MODULES: Sequence[str] = (
|
|
"yaml",
|
|
"paho.mqtt",
|
|
"paho.mqtt.client",
|
|
)
|
|
|
|
|
|
def verify_framework_version(expected_version: str = FRAMEWORK_VERSION) -> None:
|
|
"""Verifies that MAM_VERSION matches framework version if set."""
|
|
env_version = os.environ.get("MAM_VERSION")
|
|
if env_version and env_version != expected_version:
|
|
raise RuntimeError(
|
|
f"MAM_VERSION mismatch: expected {expected_version}, got {env_version} in environment."
|
|
)
|
|
|
|
|
|
def eager_load(
|
|
modules: Sequence[str] = CORE_MODULES,
|
|
optional_modules: Sequence[str] = OPTIONAL_MODULES,
|
|
) -> List[str]:
|
|
"""Eagerly imports all modules into sys.modules.
|
|
|
|
Returns the list of successfully loaded module names.
|
|
"""
|
|
verify_framework_version()
|
|
|
|
# Ensure PYTHONDONTWRITEBYTECODE is set for isolation
|
|
sys.dont_write_bytecode = True
|
|
os.environ["PYTHONDONTWRITEBYTECODE"] = "1"
|
|
|
|
loaded: List[str] = []
|
|
for mod_name in modules:
|
|
if mod_name not in sys.modules:
|
|
try:
|
|
importlib.import_module(mod_name)
|
|
except Exception as exc:
|
|
raise RuntimeError(f"Failed to eager load {mod_name}: {exc}") from exc
|
|
loaded.append(mod_name)
|
|
|
|
for opt_mod in optional_modules:
|
|
if opt_mod not in sys.modules:
|
|
try:
|
|
importlib.import_module(opt_mod)
|
|
loaded.append(opt_mod)
|
|
except (ImportError, ModuleNotFoundError):
|
|
pass
|
|
|
|
return loaded
|
|
|
|
|
|
def is_eager_loaded(modules: Sequence[str] = CORE_MODULES) -> bool:
|
|
"""Returns True if all required core modules are present in sys.modules."""
|
|
return all(mod in sys.modules for mod in modules)
|