Godopu
f57cd5cdde
- Delete adapters/cline.py and unregister from registry.py - Remove cline branches from lib.sh and all 8 skill scripts (create, resume, stop, status, reconcile, update_yaml_resumed, resolve_session_id, orc_onboard) - Narrow own-key mapping dictionaries across lib_py core modules to 4 supported agents - Delete cline-exclusive tests and retarget shared fixtures to grok/hermes/claude - Update skills documentation and installation guides (439 passed, 0 failures) - Archive cline deprecation consensus and review reports
2.4 KiB
2.4 KiB
Review: Complete cline removal
- Reviewer:
reviewer-creator-grok-01 - Job:
d78e819e - Scope: Diff vs
cline_deprecation_opinion.md§5 blast radius. No skill/framework files were edited by this review.
§5 checklist
| Requirement | Result |
|---|---|
Delete adapters/cline.py, unregister in registry.py |
Met. Adapters dir is claude.py / agy.py / hermes.py / grok.py only. |
| Remove cline from lib.sh + skill scripts | Met. Zero cline hits under .agents/skills/ (kind map, spawn-token strip, send_keys_safe case, create/resume/stop/status/reconcile/orc_onboard/run_loop, atomic_yaml / verify_session / workspace_uuid own-keys). |
Drop cline_re and cline --id / CLINE_SESSION_ID arms |
Met. is_valid_id is UUID-only. |
Keep _pane_quiescent, whitespace paste-normalize, paste-skip list (minus cline membership) |
Met. Skip list is now claude|agy|grok. Hanging-indent comment depersonalized, logic kept. |
| Retarget, don’t drop, TUI fixture tests | Met for test_c1_*. Strong/weak readiness uses a mocktiered facts stub; modal dialog test uses claude’s fullscreen upsell; SKS suffix cases use grok/claude/hermes/agy. test_o31 (node launcher + non-UUID id) was deleted, which is correct: that code path no longer exists and cannot be retargeted to a UUID agent. |
Historical .agents/reports/**/*cline* untouched |
Met. Diff does not touch those trees. VERSIONS.md / IMPROVEMENTS.md still mention cline as changelog history — leave them. |
| Single coordinated change | Met. 31 files, −411/+135. Not a cline.py-only delete. |
| Other agents unharmed | Met. hermes --yolo --accept-hooks spawn fallback, grok assigned-UUID YAML branch, claude/agy paths intact. |
Tests
pytest tests/ → 439 passed in 614.62s
Zero failures. Adapter contract, TUI readiness, orc-onboard, tier1/tier2 all green after the 5-tuple shrink.
Residual nits (do not block)
create_session.shfallbackCMD_FULLcase still omitsgrok(primary path isspawn-spec). Pre-existing, not introduced by this removal.- Create
SKILL.mdcmd_fulltable still lists only claude/agy. Docs lag, not runtime. - Changelog files (
VERSIONS.md,IMPROVEMENTS.md) still name cline; that is audit trail, not live surface.
No leftover live dispatch, no deleted shared TUI helpers, no regression in the remaining four agents. No [ESCALATE: PLANNER].
[VERDICT: PASS]