multi-agent-mux/.agents/reports/canary-projects-multi-agent-mux-creator-cline/report-143de35c.md

Cross-Code Review Report — Job 143de35c

• Job ID: 143de35c
• Reviewer: cline
• Scope: Verify P2-1 (B-6: Eliminate temporary script copy and trap leak in delegate_job_safe, commit b490713) is 100% completed and validated; audit IMPROVEMENTS.md backlog for remaining prioritized improvement opportunities (P2-2: C-3a + C-4, P2-3: C-6, P3-1: A-4 M2~M7).
• Changes under review: (no changes since base commit) — base commit is b490713 (the P2-1 fix). Only delta since base is an archived review-report doc (report-120ffb08.md, +118 lines, non-code).
• Date: 2026-08-15

---

1. P2-1 (B-6 / B-12) Verification — ✅ 100% Complete & Validated

1.1 Source Code (run_loop.sh)

delegate_job_safe() at .agents/skills/multi-agent-mux-loop/scripts/run_loop.sh:102-112 implements the fix exactly as documented:

• No temporary copy: The wrapper is executed in-place via bash "$orig_script" "$@" (line 105). The previous .tmp copy-into-.agents/skills/... tree logic is fully removed.
• No trap: No trap _mam_release_guard EXIT INT TERM HUP exists inside delegate_job_safe. The explanatory comment (lines 90-101) documents why both the copy and the trap were removed (B-6 tree pollution + B-12 subshell trap-leak firing on $(...) command-substitution subshell exit, dropping the loop lock after the first delegated job).
• Diagnostics: A local rc=0 captures the wrapper's exit code; on non-zero, log_error emits the previously-unreachable failure diagnosis (lines 106-110). Callers' own "Failed to register …" branches remain reachable for non-set -e paths.
• Residual .tmp sweep: Startup sweep of .../multi-agent-mux-delegate-job.*.tmp is retained for backwards cleanup of any pre-fix leftovers (confirmed in commit b490713 diff, run_loop.sh +26 lines).

1.2 Commit Hygiene (b490713)

git show b490713 --stat — surgical, 4 files only:

File	Δ
run_loop.sh	+26/-…
IMPROVEMENTS.md	+24
LOG.md	+12
tests/test_o3_scoped_guard.py	+167

No unrelated files touched. Every changed line traces to B-6/B-12. ✅

1.3 Tests

• tests/test_o3_scoped_guard.py + tests/test_a4_adapter_contract.py → 30 passed (includes the 4 new Z-9 behavior-based tests: test_z9_loop_lock_survives_delegation, test_z9_probe_detects_the_defect, test_z9_no_tmp_copy_left_in_skill_tree, test_z9_exit_code_and_diagnostics_propagation).
• tests/test_b7_diff_untracked.py → 20 passed (same run_loop.sh slot, confirms no regression).
• All relevant tests green; the Z-9 suite directly asserts both the "no tmp copy" (B-6) and "loop lock survives delegation" (B-12/D1) behaviors.

1.4 Syntax

• bash -n run_loop.sh → OK
• bash -n lib.sh → OK
• bash -n stop_session.sh → OK

1.5 Documentation (IMPROVEMENTS.md)

• B-6 section (line 71): marked ✅ 완료 (Stage 1) — describes in-place execution + residual .tmp sweep + failure diagnostics.
• B-12 section (line 79): marked ✅ 완료 (P0) — describes trap removal + Z-9 test replacement.
• P2-1 consolidated section (line 125): marked ✅ 완료 — merges B-6 + B-12 with full rationale.
• Priority table 6.2 row P2-1 | B-6 aligns with the completed state.

1.6 P2-1 Verdict

P2-1 is 100% completed and validated. Code, tests, syntax, and documentation are consistent and self-corroborating. The fix is minimal, surgical, and behaviorally proven by the Z-9 regression suite.

---

2. IMPROVEMENTS.md Backlog Audit — Remaining Prioritized Opportunities

Per the brief, the remaining backlog was audited against the live codebase. The header states 10 unresolved items (Architecture 2, Edge-cases 5, Orchestration 0, Legacy 3); §6.2 enumerates 12 roadmap rows (some are sub-items / decisions). Current status:

Priority	Item	Status (live code audit)	Evidence
P2-2	C-3a (4 empty isolation stubs) + C-4 (dead symbols)	🔴 Not started — all targets confirmed present	See §2.1, §2.2
P2-3	C-6 (stop_session.sh stale help text)	🔴 Not started — defect confirmed live	See §2.3
P3-1	A-4 M2~M7 (adapter main migration)	🟡 Partially done — only M0~M1 complete	See §2.4
P3-2	B-10 (agent_identities write path + PyYAML dep)	🔴 Not started	§6.2 row; depends on A-4 M2
P3-3	C-3b (isolation.root consumer disposition)	🔴 Not started	§6.2 row; depends on A-4 M2
P4-1	B-9 (LOGS_DIR import-time cwd)	🔴 Not started (low impact; 2 mitigations exist)	§6.2 row
P5-1	A-2 (public broker + HMAC)	🔴 Deferred by user instruction (P5)	§6.2 note
종결 권고	B-5 (df --output GNU flag)	⚪ Recommend close (fallback df -P works)	Line 75
—	B-11 (mount-point ERE interpolation)	🟡 Split-off recommendation from B-5 residual	Line 75
—	B-13 (in-flight tooling mutation, Stage 2)	🟡 Separated Stage 2 task	Line ~85

2.1 P2-2 / C-3a — 4 Empty Isolation Stubs (NOT done)

All 4 stubs remain in lib.sh with empty bodies, zero production callers:

• provision_isolation() — lib.sh:1369
• isolation_lever() — lib.sh:1374
• isolation_env_prefix() — lib.sh:1381
• isolation_cmd_args() — lib.sh:1385

Per §6.5, the 5 vacuous tests pinning these stubs (test_tier1_unit.py ×3, test_tier2_component.py ×1 + 1) are co-removal targets. C-3b must NOT be touched (intentionally revived in b4a1d094/44062a63). ✅ Audit consistent with live code.

2.2 P2-2 / C-4 — Dead Symbols (NOT done, list corrected to 3)

Live confirmation of the corrected 3-symbol target list:

• _REAL_HERDR_PATH — lib.sh:126 (assignment + export only, no read) ✅ present
• TERMINAL_STATUSES — multi-agent-mux-delegate-job/scripts/registry.py:38 (definition only, no reference) ✅ present
• ISOLATE — multi-agent-mux-create/scripts/create_session.sh:57 (assignment only) ✅ present

Excluded (per §6.5 correction, correctly left alone): _HERDR_SHIM_DIR_PATTERN is in use (lib.sh:57 → lib.sh:79); local_herdr already removed. Audit confirms the corrected list matches live code. ⚠️ Risk note: a naive "delete all 7" execution would break shim-path detection — §6.5 correction must be honored.

2.3 P2-3 / C-6 — stop_session.sh Stale Help (NOT done, defect live)

.agents/skills/multi-agent-mux-stop/scripts/stop_session.sh:

• Header comment (line 5): advertises [--mode soft|hard]
• usage() (line 41): does not list --mode
• Option parser (line 65): --mode|--capture-id|--graceful) → falls through to exit 2 ("unknown arg")

So the documented --mode soft|hard is rejected at runtime. ~3-line fix. ✅ Audit consistent — defect is live and reproducible.

2.4 P3-1 / A-4 — Adapter Layer (PARTIALLY done: M0~M1 only)

• M0~M1 ✅ done: tests/test_a4_adapter_contract.py → 3/3 PASS (PYTHONPATH bootstrap, deploy/CI registration, own_key migration; fanout 34→29 per prototype).
• M2~M7 🔴 not started: artifact_path/verify_artifact, spawn_spec/resume_spec/auth_ok, discover(), stop_session.sh purge path, ready_tokens migration, claude projects removal. This is the large (大) remaining structural work; gating decision for B-10 / C-3b disposition happens here.

2.5 Backlog Audit Verdict

The backlog is accurate and up-to-date as of 2026-08-15. All "not started" items were confirmed present in live code; the §6.5 corrections (C-3 split, C-4 list reduction to 3, A-2 cause rewording, B-5/B-11 split) are reflected. No stale/false "completed" claims found. The next executable, dependency-free items are P2-2 (C-3a + C-4) and P2-3 (C-6) — both small, both reduce regression time / risk.

---

3. Lint / Behavioral / Loss Review

Since (no changes since base commit), the review is a re-verification of b490713 plus a non-code backlog audit:

• Lint: bash -n passes on all 3 touched/relevant shell scripts (run_loop.sh, lib.sh, stop_session.sh); no py_compile needed (no .py changed in b490713 except the test file). ✅
• Behavioral: Z-9 tests (30 passed) + B-7 tests (20 passed) prove no tmp copy, no trap leak, loop-lock survival, and exit-code/diagnostic propagation. ✅
• Loss (regression/orphan check): git diff b490713..HEAD --stat shows only report-120ffb08.md (+118) — no code drift, no orphaned symbols introduced, no accidental removals. The b490713 commit removed the copy+trap and added diagnostics + tests; nothing was orphaned by it (the _mam_release_guard trap is still installed at loop scope, not inside delegate_job_safe). ✅

No [ESCALATE: PLANNER] warranted: P2-1 is a complete bug fix, and the remaining backlog items are already planned and prioritized in IMPROVEMENTS.md §6.2 — no re-planning/design-change needed.

---

4. Summary

Check	Result
P2-1 (B-6) tmp-copy elimination	✅ Complete — in-place bash "$orig_script"
P2-1 (B-12) subshell trap-leak fix	✅ Complete — no trap in delegate_job_safe
P2-1 tests (Z-9)	✅ 30 passed
P2-1 syntax (bash -n)	✅ OK
P2-1 commit hygiene	✅ Surgical (4 files)
Backlog P2-2 (C-3a + C-4)	🔴 Not started — targets confirmed live (corrected to 3+4)
Backlog P2-3 (C-6)	🔴 Not started — stale --mode help confirmed live
Backlog P3-1 (A-4 M2~M7)	🟡 M0M1 done (3/3); M2M7 pending
Backlog accuracy	✅ Matches live code; §6.5 corrections honored
Lint / Behavior / Loss	✅ Clean

P2-1 is fully implemented, tested, and documented. The remaining backlog is accurately tracked and correctly prioritized; the next low-cost, dependency-free items are P2-2 and P2-3.

[VERDICT: PASS]