Fix pexec('echo foo', shell=True)

2012-05-16 23:59:12 -07:00
parent 2f8dfe5810
commit b91008345f
1 changed files with 5 additions and 0 deletions
@@ -297,6 +297,8 @@ class Node( object ):
            elif type( args[ 0 ] ) is str:
                # popen("cmd arg1 arg2...")
                cmd = args[ 0 ].split()
+            else:
+                raise Exception( 'popen() requires a string or list' )
        elif len( args ) > 0:
            # popen( cmd, arg1, arg2... )
            cmd = args
@@ -304,6 +306,9 @@ class Node( object ):
        mncmd = defaults[ 'mncmd' ]
        del defaults[ 'mncmd' ]
        cmd = mncmd + cmd
+        # Shell requires a string, not a list!
+        if defaults.get( 'shell', False ):
+            cmd = ' '.join( cmd )
        return Popen( cmd, **defaults )

    def pexec( self, *args, **kwargs ):