Bob Lantz
acdcf9b6ae
cluster: add batchStartup/Shutdown, cleanup
2015-01-27 15:27:26 -08:00
Bob Lantz
c702840a0a
Remove debug print lines
2015-01-27 15:24:29 -08:00
Bob Lantz
254fae2dc9
Clarify which intf pair failed and raise exception
2015-01-27 15:23:48 -08:00
Bob Lantz
bdad3e8c8e
Merge OVSBatch into OVSSwitch
...
Note that we are changing the interface of batchStartup/Shutdown
slightly so that the method can choose not to start some of the
switches. We might wish to refine this a bit...
2015-01-26 18:01:20 -08:00
Bob Lantz
574d634fc2
Don't clean up links that may have been dumped into root NS.
...
This should rarely happen - in the usual case, either the
links will be shut down by Mininet.stop(), or the interfaces
will be deleted by node.stop( deleteIntfs=True ), or the
links or interfaces will be explicitly deleted or stopped
using the low-level API.
Cases that are relying on links being automatically deleted
in cleanup() will potentially find that they are now no longer
deleted, but these cases should be rare.
2015-01-26 14:06:23 -08:00
Bob Lantz
eafbd2a597
Change to OVSSwitch
2015-01-26 14:06:23 -08:00
Bob Lantz
7485b035af
make 'ovs-vsctl' string symmetric
2015-01-26 14:06:23 -08:00
Bob Lantz
8014a7023c
Fix super() typo
2015-01-26 14:06:23 -08:00
Bob Lantz
bec34e7227
Clean up - TCReapply still broken!
2015-01-26 14:06:23 -08:00
Bob Lantz
9ca6322603
Remove shared reconnectms, improve self.started
...
We still need to set it in batchShutdown()
2015-01-26 14:06:23 -08:00
Bob Lantz
957fe1db93
Refactor for compatibility with isOldOVS() == True
2015-01-26 14:06:23 -08:00
Bob Lantz
3b4738c2ca
First crack at setting controller backoff in single command
2015-01-26 14:06:23 -08:00
Bob Lantz
30ebb852a3
errRun: add debug( results )
2015-01-26 14:06:22 -08:00
Bob Lantz
959586bc8f
Add debug(cmd) to errRun()
2015-01-26 14:06:22 -08:00
Bob Lantz
9bda98486d
Add OVSBatch class (experimental)
...
This implements batch startup for OVS switches.
2015-01-26 14:06:22 -08:00
Bob Lantz
c68e4e76f4
Clarify bandwidth limit for TCIntfs
...
In the future, we would like to support higher bandwidth
limits for TCIntfs, but we'll probably need to adjust some
of the parameters dynamically.
2015-01-26 13:55:38 -08:00
Bob Lantz
98a8231cef
Exit poll loop on POLLHUP or anything unexpected
...
In my opinion, we really shouldn't even get POLLHUP, but
we do. In case we get anything else odd, quite polling on
that fd.
2015-01-23 16:43:49 -08:00
Bob Lantz
28ce13d18e
Fix polling in errRun
...
It's tricky to get this right, but basically we want to read
if there is something to read; if not, we want to check for
EOF.
2015-01-23 16:41:29 -08:00
Bob Lantz
ef59cd88dc
Return correct success condition in cgroupDel
...
Without this, we end up retrying until we fail, instead
of returning immediately on success!
2015-01-23 16:39:50 -08:00
Bob Lantz
9db6cdc261
Call delete() in link.stop() ; warn on exited node.cmd()
...
We should think a bit about the semantics that we want here.
The comments say "stop and clean up link" so perhaps that's
what we want. However, we could also imagine stop stopping
forwarding on the link (and possibly allowing restarts).
We warn on exited node.cmd() because we terminate the controller
before stopping/deleting the links. This makes sense to avoid a
storm of link/port down events, but since the controller's
shell has exited we cannot call link.stop() on any of its
links. We may want to simply stop the controller and not
terminate it, but at least it doesn't hang for now.
2015-01-22 03:22:43 -08:00
Bob Lantz
f7b29333f5
2.2.0 -> 2.2.0+
2015-01-18 23:35:54 -08:00
Bob Lantz
24520fc982
Allow + in version number
2015-01-18 23:35:29 -08:00
Bob Lantz
b93cc989f4
Pass code check
2015-01-18 23:35:12 -08:00
Bob Lantz
a8cc243aa7
Add stp param to OVS and connected() to OVSBridge
...
This allows --switch ovsbr,stp=True to work correctly
2015-01-18 22:59:21 -08:00
Bob Lantz
e65dc4c6d6
OVSLink: use isinstance() to detect OVSSwitch subclasses
2015-01-18 21:56:38 -08:00
Bob Lantz
d4be92713a
Merge del-br into cmd, and add reconnectms param
...
With newer versions of OVS, this allows us to set up a switch
with a single OVS command (if reconnectms is zero.) If reconnectms
is specified, then it slows things down slightly (but not much.)
2015-01-18 16:09:02 -08:00
Bob Lantz
79f5d39db5
Comment edits and pass code check
2015-01-17 13:56:37 -08:00
Bob Lantz
6da3fcdef1
Add bridges s1-s3 to topology and explain some details
2015-01-17 13:38:55 -08:00
Bob Lantz
026130bd5f
pass code check
2015-01-17 13:33:59 -08:00
Bob Lantz
c1b48fb5c8
Stub out RemoteOVSSwitch.batchShutdown()
...
Eventually we should implement true batch shutdown.
In the mean time, we just ignore it. Note there's no good
way that I know of for a subclass to remove a superclass
method, so we changed the protocol a bit to require a return
value of True.
2015-01-15 02:43:38 -08:00
Bob Lantz
b1983548aa
Fix indentation error
2015-01-15 02:36:34 -08:00
Bob Lantz
c62812a944
Update cluster.py for new makeIntfPair
2015-01-15 02:29:51 -08:00
Bob Lantz
d66b96260a
Don't stop switches that we've already stopped.
...
Note that this also changes the way that links are deleted;
the reason is that the batch shutdown doesn't currently delete
the links, but OVSSwitch.stop() does. We may wish to revisit
this in the future.
2015-01-15 02:07:00 -08:00
Bob Lantz
d7e9c3bbfd
Add comment about redundant intf.delete()
2015-01-15 02:07:00 -08:00
Bob Lantz
7a4a865bdb
customize makeIntfPair to eliminate fastIntfPair
2015-01-15 02:07:00 -08:00
Bob Lantz
da4dcf3753
Add addresses to fastIntfPair() and fix codecheck
2015-01-15 02:07:00 -08:00
Bob Lantz
5383b0e603
Update comment to reflect OVS patch link limits
2015-01-15 02:07:00 -08:00
Bob Lantz
9d2e6404b3
add fastIntfPair to speed up link creation
2015-01-15 02:07:00 -08:00
Bob Lantz
91a73bd191
use isinstance( intf, OVSIntf )
2015-01-15 02:07:00 -08:00
Bob Lantz
c069542c5c
Add OVSLink/--link ovs, which uses OVS patch links when possible
2015-01-15 02:07:00 -08:00
Bob Lantz
127f35a9bc
Revert to using OVS default OpenFlow versions.
...
It makes sense to follow Open vSwitch's lead here.
OVS 2.3 enables OpenFlow 1.0 through 1.3 by default.
OVS 2.0 has incomplete support for 1.3, but you can enable
it with protocols=OpenFlow13
2015-01-14 14:18:53 -08:00
Bob Lantz
171e815122
Set OVSSwitch default protocols to OpenFlow10,OpenFlow13
...
For OVS versions 1.9 or earlier, this setting is ignored.
2015-01-14 14:15:14 -08:00
Bob Lantz
3ac5cafe53
Fix code minor code check errors
2015-01-06 16:26:33 -08:00
Bob Lantz
a7ad739036
Disable IPv6 via grub command line
...
Unfortunately disabling IPv6 via sysctl doesn't actually
disable it on all of the interfaces by default. Disabling
it via grub disables it entirely in the VM.
Helps with #454
2014-12-17 13:49:12 -08:00
Bob Lantz
a84bec9709
Disable splash and quiet individually (more robust)
2014-12-17 13:48:43 -08:00
Bob Lantz
05dbf82edb
Correctly set controller backoff for OVS.
...
Also report connected in standalone/bridge mode
Fixes #460
Conflicts:
mininet/node.py
2014-12-11 17:03:49 -08:00
Bob Lantz
c75eb47158
2.2.0rc1 -> 2.2.0
2014-12-09 13:37:43 -08:00
Bob Lantz
9945864a32
2.2.0rc1 -> 2.2.0rc2
...
Basically no changes except for whitespace and satisfying pep8.
2014-12-08 15:37:50 -08:00
Bob Lantz
beeea4b292
Exclude miniedit from pep8 checking for now
...
(Also untabbed comment lines, flagged by emacs et al.)
2014-12-08 15:27:13 -08:00
Bob Lantz
7a3159c9af
Spacing tweaks for pep8 checker
2014-12-08 15:10:32 -08:00
Bob Lantz
ccd6b5cd7d
version -> 2.2.0rc1 and update copyright date
2014-12-04 09:28:19 -08:00
Bob Lantz
908e85d9f9
Remove PLFMT since options are moved to .pylint
2014-12-04 09:27:53 -08:00
Bob Lantz
e341526f46
Raise line limit to 4000 for miniedit.py (see note)
...
Future versions of pylint will allow this to be disabled
in the file itself, so we can drop the limit back to
1500 or something more reasonable!!
2014-12-04 09:26:11 -08:00
Bob Lantz
03461ce908
Add 'slowtest' make target to test walkthrough, examples
2014-12-04 09:17:13 -08:00
Bob Lantz
8c37975d44
Remove erroneous self.cmd = None
2014-12-04 09:03:46 -08:00
Bob Lantz
4d55ef1132
Restore missing space in RT_GROUP_SCHED message
2014-12-04 08:57:28 -08:00
Bob Lantz
342d47cfb5
call to run() should be to runCmd()
2014-12-04 08:56:08 -08:00
Bob Lantz
554abdd57a
warn -> debug in connected; change IVS class comment
2014-12-04 08:38:54 -08:00
Bob Lantz
061598f011
Change from numeric to symbolic pylint error codes
2014-12-04 08:21:53 -08:00
Bob Lantz
d754a7ceea
Call super(deleteIntfs)
...
Maybe this is better - maybe not. ;-p
2014-12-04 07:36:53 -08:00
Bob Lantz
643c9f912f
More pylint changes...
2014-12-04 05:55:57 -08:00
Bob Lantz
4965421215
More pylint fixes...
2014-12-04 02:57:36 -08:00
Bob Lantz
18aab5b786
More pylint changes
2014-12-04 00:51:05 -08:00
Bob Lantz
b905dddf19
Reorganize and pass pylint
2014-12-02 20:26:34 -08:00
Bob Lantz
11a9c46904
Fix missing imports
2014-12-02 23:22:56 -08:00
Bob Lantz
b1ec912db5
Fixing pylint errors
2014-12-02 23:00:50 -08:00
Bob Lantz
db45b7c644
Parseable output format for newer pylint
2014-12-02 23:00:14 -08:00
Bob Lantz
2256a53830
Fix pylint error
2014-12-02 22:59:32 -08:00
Bob Lantz
03ef55672d
Add cleanup and fix pylint errors
2014-12-02 22:58:57 -08:00
Bob Lantz
c45bfab318
Add cleanup
2014-12-02 22:58:38 -08:00
Bob Lantz
b2fcab827d
Add cleanup and fix pylint errors
2014-12-02 22:58:10 -08:00
Bob Lantz
1471da95a9
Fix pylint errors
2014-12-02 22:57:32 -08:00
Bob Lantz
5a530af189
Remove trailing whitespace. ;-/
2014-12-01 15:39:44 -08:00
Bob Lantz
3c9f5ad56e
Disable pep8 whitespace errors
2014-12-01 15:38:38 -08:00
Bob Lantz
c5d9e0e03c
Set default route in one cmd line to avoid dc'ing root NS
...
Usually you won't want to create a node in the root namespace,
and usually you won't want to use the Mininet API to set your
(real) default route, but if you do then you will probably want
to use a single command line to avoid disconnecting an SSH
session while we wait for the reulst of the 'ip route del default
command.
2014-12-01 15:10:44 -08:00
lantz
7a411b6bb5
Merge pull request #453 from cdburkard/master
...
update examples README with new examples
2014-11-25 13:01:31 -08:00
Bob Lantz
4219b22978
2.2.0b2
2014-11-24 19:35:34 -08:00
lantz
08ab7e8de7
Merge pull request #452 from mininet/nat-cmd
...
Updating NAT class to use gateway interface
2014-11-24 19:13:33 -08:00
lantz
3ef6bcface
Additional info about --nat and LinuxRouter
2014-11-24 19:04:15 -08:00
lantz
015cd9e776
Merge pull request #443 from cdburkard/devel/cluster
...
use rcmd instead of quietRun when shutting down remote nodes
2014-11-24 12:30:52 -08:00
Bob Lantz
3d44bcdcc4
MiniNet -> Mininet
2014-11-23 17:32:11 -08:00
Bob Lantz
1817cbc3a4
Pass pyflakes
2014-11-23 17:31:43 -08:00
Bob Lantz
e0bf8ece3c
Minor code cleanup
2014-11-23 17:17:21 -08:00
Bob Lantz
37bdf14b49
Rename examples.{intfOptions,multiLink} -> {intfoptions,multilink}
2014-11-23 17:11:06 -08:00
Bob Lantz
292e69f89a
Renamed to intfoptions.py for consistency
2014-11-23 17:07:32 -08:00
Bob Lantz
dd876e69c8
DemoCLI -> ClusterCLI
2014-11-23 17:04:07 -08:00
lantz
4e644d7465
Merge pull request #450 from mininet/sw-cmd
...
adding deleteIntfs option to switches and corresponding CLI command
2014-11-24 11:27:59 -08:00
lantz
596fd9d0c6
Merge pull request #449 from cdburkard/devel/cluster_controlPaths
...
use ControlPersist ssh option to fix ControlPath shutdown
2014-11-23 14:59:11 -08:00
Bob Lantz
474f68600e
Make pylint happier for no particular reason
2014-11-23 11:13:54 -08:00
Bob Lantz
50774e407c
Remove unused imports
2014-11-23 11:11:03 -08:00
Bob Lantz
8e63e2c540
Fix undefined sleep()
2014-11-23 11:10:43 -08:00
Bob Lantz
273c4e9403
Fix typo. ;-p
2014-11-23 11:09:21 -08:00
Bob Lantz
c273f49077
type( foo ) is bar -> isinstance( foo, bar )
2014-11-23 11:06:12 -08:00
Bob Lantz
9a8bdfd765
use isinstance( obj, basestring) to allow unicode strings
...
fixes #448
2014-11-23 10:59:08 -08:00
Bob Lantz
f0f9907b9d
Add setup() and dpctl() methods for LinuxBridge
...
Also adds docstrings.
Fixes #422
2014-11-19 09:32:56 -08:00
Bob Lantz
c4fc630413
Correctly call cli() rather than CLI()
2014-11-19 09:18:05 -08:00
Bob Lantz
aabbf29542
Revert to old "Adding controller" message
2014-11-19 08:58:17 -08:00
lantz
d37d6ecd99
Merge pull request #241 from moijes12/fix44
...
(pending) Create test_switchdpidassignment.py
2014-11-20 14:14:14 -08:00
Bob Lantz
e4db698184
Fix indentation error so we don't wait forever.
2014-11-19 05:58:36 -08:00
lantz
e661a4b1c3
Merge pull request #447 from rlane/ivs-verbose-off
...
IVSSwitch: turn off verbose logging by default
2014-11-20 11:56:42 -08:00