2.6 KiB
Issue #5 release-version review
Job: e5c9a052
Reviewer: planner-reviewer-codex-01 (planner,reviewer)
Reviewed commit: 3874797 on main, following merge b347efd.
Approve the v4.4.0 version update. No blocking mismatch or regression was found in this release patch. No implementation edits or escalation were necessary.
Version decision and consistency
A large internal Bash-to-Python migration does not by itself require a major version. The retained script entry points and compatibility paths, together with additive opt-in functionality, support v4.4.0 rather than requiring v5.0.0 solely because of architectural size. This assessment concerns the release patch and documented compatibility boundary; it is not a new exhaustive audit of all Phase 3/4 behavior.
Verified lockstep across lib.sh MAM_VERSION, eager.py FRAMEWORK_VERSION, VERSIONS.md current release and eight-row skill matrix, and all eight SKILL.md frontmatter versions. They consistently specify 4.4.0. README/BOOTSTRAP and contract references were updated with the release.
The consistency test now covers the previously separate runtime constant. Replacing the Phase 4 test's hardcoded version with a check of the actual constant is appropriate because the dedicated consistency test owns the cross-file equality assertion. Explicit mismatch tests still exercise rejection.
The test-session removal of inherited MAM_VERSION isolates the tree under test from a pre-upgrade launcher. It does not disable the production gate: run_loop.sh sources lib.sh before Python startup, and the test explicitly setting a mismatched version still fails closed as intended.
Nonblocking release-note precision
VERSIONS.md's blanket statement that no public behavior/exit code changed is stronger than the evidence cited. Earlier phases deliberately added CAS refusal outcomes and stricter verdict handling. Describe preserved supported contracts and intentional safety corrections explicitly. Likewise, rollback switches are operational escape paths, not proof of SemVer compatibility. These wording qualifications do not require changing the selected version or block the synchronized version patch.
Validation
./.venv/bin/python -m pytest tests/test_version_consistency.py tests/test_issue5_phase4_runtime.py -q: 8 passed in 1.23s.git diff --check: clean; working tree clean before writing this assigned report.- Inspected release commit scope, constants/matrix/frontmatters, new test isolation fixture and runtime-gate test changes.
- Release notes report 750 full-suite passes; this reviewer independently ran only the eight relevant version/runtime tests and does not claim a repeated full-suite run.
[VERDICT: PASS]