Godopu
f57cd5cdde
- Delete adapters/cline.py and unregister from registry.py - Remove cline branches from lib.sh and all 8 skill scripts (create, resume, stop, status, reconcile, update_yaml_resumed, resolve_session_id, orc_onboard) - Narrow own-key mapping dictionaries across lib_py core modules to 4 supported agents - Delete cline-exclusive tests and retarget shared fixtures to grok/hermes/claude - Update skills documentation and installation guides (439 passed, 0 failures) - Archive cline deprecation consensus and review reports
2.4 KiB
2.4 KiB
Report: Job e30b9201 — Refined Cline Removal Plan (Rev.2) per creator-agy-01 Challenge
Durable output (updated in place): .agents/reports/planner-reviewer-claude-01/plan-264c3b5d.md
Summary
creator-agy-01 challenged Rev.1's test-retargeting strategy (§5) and doc-scope decision (§6), identifying one core blind spot and two supporting gaps. All accepted — no [REBUT:] filed, after independently re-verifying each claim:
- Core blind spot: Rev.1 proposed retargeting the 2-tier readiness tests by pre-exporting
MAM_STRONG_READY_TOKENS/MAM_WEAK_READY_TOKENSenv vars directly. I re-checkedlib.shmyself and confirmed this would skipwait_for_tui_ready'spython -m lib_py.agents facts <agent>bridge call entirely (it's gated behind an[ -z "$strong_tokens" ]check) — since cline was the only real adapter with non-degenerate 2-tier values, this would leave the bridge's handling of genuinely-differentiated strong/weak tokens completely untested once cline is gone. Fixed: retarget to a test-local mock adapter instead, keeping the real facts bridge in the loop. test_c8gap: Rev.1 only swapped the modal text, missing that the test's session name (my-project-worker-cline-01) drives dynamic agent resolution →facts cline— a synthetic modal string wouldn't fix that the session name itself would fail to resolve once cline's adapter is deleted. Fixed: retarget the whole test toclaude, using claude's own realmodal_tokensvalue (Try the new fullscreen renderer?, verified present inclaude.py), preserving the complete E2E path with an agent that isn't being removed.- Added a new adapter-contract assertion (all 4 remaining agents' default 2-tier fields round-trip correctly through the facts bridge) to close the coverage gap explicitly.
docs/NEW_AGENT_INTEGRATION_GUIDE.md: I'd placed this in "do not touch," but verified myself it's a live copy-paste template withclinehardcoded into 5 sample sites (adapter dict,lib.shkind mapping, binary tuple, diagram, test assertion) — moved into the update-scope in §6.
Full Rev.2 text with the corrected test-retargeting specifications is in the durable plan linked above.
Process note: still pending a fresh [VERDICT: PASS] before implementation begins, per MULTI_AGENT_RULES.md §3.1.
[VERDICT: N/A — planning artifact, review pending]