39 lines
2.6 KiB
Markdown
39 lines
2.6 KiB
Markdown
# Cross-review: v4.1.0 3-way lockstep bump
|
||
|
||
- **Reviewer**: `reviewer-creator-grok-01`
|
||
- **Job**: `e596c82c`
|
||
- **Scope**: bump `MAM_VERSION` / `VERSIONS.md` / 8× `SKILL.md` to `4.1.0` per the Rev.2 rec (`v4.0.0 → v4.1.0` MINOR, OpenCode backend)
|
||
- **Method**: live-file inspection + `git diff` of lockstep surfaces; did not trust the changelog's 447 claim until re-run.
|
||
|
||
---
|
||
|
||
## Checklist vs live tree
|
||
|
||
| Rec / brief item | Status |
|
||
|---|---|
|
||
| `lib.sh:32` `MAM_VERSION="4.1.0"` (not env-overridable) | **Met.** Diff is that one assignment. `test_mam_version_is_not_env_overridable` passed (`MAM_VERSION=9.9.9` does not stick). |
|
||
| `VERSIONS.md` header `v4.1.0`, date **2026-08-29** | **Met.** |
|
||
| Matrix prose (the sentence the lockstep regex does **not** cover) | **Met.** Now: `…v4.1.0으로 동기화되어 배포됩니다.` (shifted from old line 24 to line 26 because a new architecture bullet was inserted; content is correct). |
|
||
| 8-row skill matrix all `` `4.1.0` `` | **Met.** All eight named skills present. |
|
||
| Changelog `### v4.1.0` OpenCode integration | **Met.** Uses the project's existing `### 🚀 \`v4.1.0\` — OpenCode AI Agent Integration (2026-08-29)` form, matching `v4.0.0`'s heading style. Documents `--agent opencode`, `OPENCODE_PERMISSION` empty-guard, `opencode db path`, `directory`/`time_created` ms. |
|
||
| 8× `SKILL.md` `version: 4.1.0` | **Met.** Frontmatter-only diffs (`4.0.0` → `4.1.0`); no body loss. |
|
||
| Historical `v4.0.0` section preserved | **Met.** Only remaining `4.0.0` literal in `lib.sh`/`VERSIONS.md`/`SKILL.md` is the `### 🚀 \`v4.0.0\`` changelog header. |
|
||
|
||
`tests/test_version_consistency.py`: **2 passed** (`test_three_way_version_lockstep`, `test_mam_version_is_not_env_overridable`).
|
||
|
||
Full suite `pytest tests/ -q`: **447 passed in 668.68s**. Independently confirms the current-release "447 passed / 0 failed" bullet and changelog F-3.
|
||
|
||
No lint/behavior/loss issue on the lockstep edit surface. Changelog F-2 names the real wired scripts (`create`/`resume`/`stop`/`status`/`reconcile`/`run_loop`/`orc_onboard`) and does **not** claim `delegate-job` — consistent with the rec's scope note.
|
||
|
||
## Residual nits (do not block)
|
||
|
||
- `.agents/reports/version_upgrade_recommendation.md` still reads "Current Version: v4.0.0 / Proposed: v4.1.0" (the rec, not the lockstep). Expected once the bump lands; not a lockstep file.
|
||
- Extra untracked docs (`docs/OPENCODE_OLLAMA_GUIDE.md`, archived reviewer reports) are outside this bump's 3-way surface.
|
||
- Current-overview bullet still titles cline removal as a *current* architecture point (now "Core 5-Agent Whitelist"). Historical, not a version desync.
|
||
|
||
No `[ESCALATE: PLANNER]`.
|
||
|
||
---
|
||
|
||
[VERDICT: PASS]
|