43 lines
1.7 KiB
Markdown
43 lines
1.7 KiB
Markdown
# Issue #5 Phase 1 review (`265a1f6`..`6ad6f08`, HEAD)
|
|
|
|
- **Reviewer**: `reviewer-creator-grok-01`
|
|
- **Job**: `c4f0ffc7`
|
|
- **HEAD**: `6ad6f08` (docs residuals) on top of `95f3e9a` (R1/R2/F-1)
|
|
- **Tests this turn**: `pytest tests/test_issue5_phase1_delegation.py tests/test_version_consistency.py` → **68 passed**. `git diff --check fc0bd96..HEAD` clean.
|
|
|
|
---
|
|
|
|
## Code (R1 / R2 / F-1 / O-1)
|
|
|
|
Already sustained in job `8d4e0e0e`. Re-checked on HEAD:
|
|
|
|
- **R1**: `_delegation_py` (`lib.sh:1960-1967`) uses `python -c` + `sys.path.insert(0, SKILL_DIR)`, not `-m`. cwd unchanged. `test_r1_*` still in the 68.
|
|
- **R2**: `_fingerprint` is the full `BrokerConfig` field set; mismatch names fields, not values.
|
|
- **F-1**: `_send` maps only `MQTT_ERR_NO_CONN` → `ConnectionError`; retry tuple unchanged. `FakeInfo.rc` matches paho.
|
|
- **O-1**: `_publish_once` → `OneShotPublisher.publish_raw`.
|
|
|
|
Loop still submits via `delegate_job_safe` (wrapper), not `_delegation_py`. Auto-complete: `run_loop.sh` untouched in this fix series.
|
|
|
|
---
|
|
|
|
## Residuals from Round 2 — closed or parked
|
|
|
|
| Item | Status |
|
|
|---|---|
|
|
| Benchmark fork table still said `-m` | **Closed** in `6ad6f08`. Table names `_delegation_py` → `python -c` + insert; note explains why `-m` was dropped. |
|
|
| Freeze `_delegate_py_bin` walks to system python (no paho) | **Parked on P3-02** (`task.md:94`). Accurate: freeze dir has no `.venv`; Phase 1 production path is the wrapper, not frozen helpers. Must fix when Phase 3 calls those helpers from freeze `lib.sh`. |
|
|
|
|
---
|
|
|
|
## Round 1 Grok error
|
|
|
|
`PYTHONPATH=$SKILL_DIR` + `python -m` is **not** B-13. `-m` puts cwd first. R1 fix is the real guarantee.
|
|
|
|
[ADJUDICATION: SUSTAINED] on R1/R2/F-1.
|
|
|
|
No `[ESCALATE: PLANNER]`.
|
|
|
|
---
|
|
|
|
[VERDICT: PASS]
|