41 lines
4.8 KiB
Markdown
41 lines
4.8 KiB
Markdown
# 🔍 Post-Commit Cross-Review — v4.1.3 Release Packaging (Commit `85a46ef`, Job `4d3c2c1c`)
|
|
|
|
- **Reviewer**: `planner-reviewer-claude-01`
|
|
- **Target**: commit `85a46ef` — "chore(release): bump framework and 8 skills to v4.1.3" (already on `main`; no uncommitted diff to review, so this is a post-commit audit against the checklist).
|
|
- **Method**: read the actual commit via `git show`, verified every touchpoint against live file content, ran the version-lockstep tests and the full suite myself.
|
|
|
|
---
|
|
|
|
## 1. 3-Way Version Lockstep
|
|
|
|
- `lib.sh:32`: `MAM_VERSION="4.1.3"` — confirmed exact, single-line change, comment/export logic untouched.
|
|
- `VERSIONS.md`: current-version header now `v4.1.3` / `2026-08-31 (KST)`; all 8 rows of the skill matrix updated to `4.1.3`; new `### 🛠️ v4.1.3` changelog section inserted correctly *above* the existing `v4.1.2` entry (chronological order preserved), with accurate C-1/C-2 bullets that match the actual code changes and cite the correct tests (`test_h26`, `test_t14`, `test_t16`, `test_t15`).
|
|
- All 8 `SKILL.md` frontmatters (`create`, `stop`, `resume`, `status`, `monitor`, `delegate-job`, `loop`, `orc-onboard`): each diff is a clean, isolated `version: 4.1.2` → `4.1.3` line change — no other frontmatter fields touched, verified by reading every one of the 8 diff hunks directly.
|
|
- `tests/test_version_consistency.py`: ran both `test_three_way_version_lockstep` and `test_mam_version_is_not_env_overridable` myself — **both PASS** at the new v4.1.3 state.
|
|
|
|
Lockstep is fully correct and complete.
|
|
|
|
## 2. Reviewer-feedback doc sync (`multi-agent-mux-resume/SKILL.md`) — one real inaccuracy found
|
|
|
|
**Line 55** ("UUID resolution order" prose): correctly and accurately updated — *"If both are empty → for Class A agents (`agy`, `hermes`, `opencode`), `resume_session.sh` automatically falls back to `FRESH_SPAWN=1` (`spawn-spec`). For Class B agents (`claude`, `grok`), fall back to `multi-agent-mux-create`."* This precisely matches the real, already-verified `resume_session.sh` behavior.
|
|
|
|
**Lines 71-75** (the "Workflow" section's illustrative bash snippet): here I found a genuine content inaccuracy. The added comment says *"For Class A, `resume_session.sh` handles fresh-spawn fallback automatically"* — correct — but the `echo` text right below it on the very next line was changed to:
|
|
```
|
|
echo "No saved session for $WORKSPACE ($AGENT). Class B agents must use multi-agent-mux-create first."
|
|
```
|
|
I checked the **actual, live** `resume_session.sh` error string (line 67): it is byte-for-byte unchanged from before this whole Issue #3 effort — `"ERROR: No saved session for $WORKSPACE ($AGENT). Use multi-agent-mux-create first."` — with no "Class B agents must" phrase anywhere in it (I deliberately preserved this exact string across `a9c8d6d3`/`398afb2e` specifically because Class B's contract was to stay byte-identical). The doc's illustrative snippet now shows a **fabricated error string that the real script never actually prints**.
|
|
|
|
This is a pre-existing pattern of the "Workflow" section being a simplified, non-literal walkthrough (it has never had an `opencode` case arm in its `case "$AGENT" in ...` blocks, for instance, even though `opencode` is a supported agent — that gap predates this release and is out of scope here). But this specific edit *introduces* a new inaccuracy rather than just continuing the existing simplification: previously the illustrative echo text matched the real error message nearly verbatim (modulo the missing `ERROR:` prefix); now it doesn't match at all. A reader who greps for this exact string against real output, or who takes the snippet as literal, would be misled.
|
|
|
|
**This is non-blocking**: it's confined to an illustrative code comment/example (not the authoritative prose above it, which is correct), doesn't affect any runtime behavior, and doesn't touch the 3-way lockstep contract. Recommend a follow-up one-line fix: either revert the echo text to the real script's exact string, or make the whole `if [ -z "$UUID" ]` block in the example actually branch on agent class (mirroring the real script) instead of adding a claim the flat example doesn't back up.
|
|
|
|
## 3. Full regression sweep
|
|
|
|
Ran myself at the current `HEAD` (post-`85a46ef`): **455 passed, 0 failed**, 12m31s. `git status` clean (no uncommitted drift).
|
|
|
|
## 4. Verdict
|
|
|
|
The 3-way version lockstep is fully correct and test-verified; the changelog is accurate; the primary documentation-sync requirement (line 55) is correct. One non-blocking documentation inaccuracy found and specifically located (lines 71-75's example error text doesn't match the real script's preserved error string) — recommend a small follow-up fix, but it does not affect release correctness, runtime behavior, or the lockstep contract this commit was packaging. No lint/functional defects in the actual shipped code or version files.
|
|
|
|
[VERDICT: PASS]
|