1.8 KiB
1.8 KiB
Post-commit review: v4.1.3 3-way lockstep (85a46ef)
- Reviewer:
reviewer-creator-grok-01 - Job:
1acf4fb0 - Commit:
85a46ef chore(release): bump framework and 8 skills to v4.1.3 (PATCH — herdr daemon isolation & Class A 0-turn resume reliability fixes) - Working tree vs that bump: subsequent
4b2f703is docs-only report archive; live lockstep files match85a46ef.
1. 3-way lockstep
| Surface | Live |
|---|---|
lib.sh:32 |
MAM_VERSION="4.1.3" |
VERSIONS.md header |
v4.1.3, date 2026-08-31 |
| Line 21 prose | v4.1.3으로 동기화되어 배포됩니다. |
| 8-row matrix | all `4.1.3` |
| Changelog | ### 🛠️ \v4.1.3` — Herdr Daemon Isolation & Class A 0-Turn Resume… (C-1 setsid, C-2 FRESH_SPAWN + epoch; Class B hatch/test_t8/test_t15named).v4.1.2` section preserved. |
8× SKILL.md version: |
all 4.1.3 |
pytest tests/test_version_consistency.py -v → 2 passed (test_three_way_version_lockstep, test_mam_version_is_not_env_overridable).
No leftover 4.1.2 on current-facing lockstep surfaces (only the historical ### v4.1.2 changelog header).
2. Resume SKILL.md body (ec2e02e2 nit)
- Line 55: Class A empty UUID →
FRESH_SPAWN=1/spawn-spec; Class B →multi-agent-mux-create. Matchesresume_session.sh. Met. - Lines 71–74: comment states Class A is handled inside
resume_session.sh; the example stillexit 1for every empty UUID. Copy-pasting the Workflow block would not reproduce Class A fallback. Residual docs nit, not a lockstep failure.
Residual nits (do not block)
- Workflow snippet 71–74 still unconditional
exit 1(see above). - Pitfall “Don't resume if the session is brand new and empty” (line 123) is slightly stale vs Class A 0-turn resume.
No [ESCALATE: PLANNER].
[VERDICT: PASS]