2.3 KiB
2.3 KiB
Re-review: OpenCode adapter plan (Rev.3)
- Reviewer:
reviewer-creator-grok-01 - Job:
d7638266(follow-up to56120ad3[VERDICT: NOT PASS]) - Artifacts:
.agents/reports/planner-reviewer-claude-01/plan-de667f0f.md(canonical) and identical.agents/reports/implementation_plan.md. Rootimplementation_plan.mdis the NATS roadmap again (unstaged; matches HEAD).
Prior blocking items
| ID | Rev.2 defect | Rev.3 |
|---|---|---|
| F1 유실 | NATS implementation_plan.md overwritten |
Fixed. Root file is the messaging roadmap again. OpenCode plan lives under .agents/reports/planner-reviewer-claude-01/plan-de667f0f.md. |
| F2 lockstep holes | create spawn/YAML/CMD_FULL, SKS, test_tier1, SKILL.md, conftest missing | Fixed. Table items 23–29 match the live files (spawn agy|hermes|grok ~204, YAML elif ~399–419, SKS ~2058–2061, test_tier1 ~969/974). |
| F3 storage path | hardcoded storage.db; opencode db path called unofficial |
Fixed. Spike starts with opencode db path; drift-C uses _resolve_opencode_db. SQL still assumes cwd/created_at until the spike — correctly gated in §6 DoD. |
| F4 unattended | --auto only; missed OPENCODE_PERMISSION |
Fixed. Process env OPENCODE_PERMISSION='{"*":"allow"}' plus empirical DoD. |
F5 auth_ok |
os.path.expanduser('~') |
Intent fixed (ctx.home_dir in the table). See nit below. |
Architecture from Rev.2 (agy/hermes bucket, dedicated drift-C, no pre-assigned UUID, copy-hermes not generic refactor in this PR) is unchanged and still correct.
Residual nits (do not block)
auth_okhas noctx.BaseAgentAdapter.auth_ok(self, run_cmd=None)matches grok:HOME_DIRorHOME, notctx. Implement likegrok.py; keepctx.home_dironverify_artifact/discover/purge_artifacts.- Export at spawn. Documenting
OPENCODE_PERMISSIONin.mam.env.exampleis not enough unlesscreate_session.sh/resume_session.shexport it for--agent opencodebeforeherdr new-session. One sentence in item 23/25 is enough at implement time. - Two identical copies of the plan (
plan-de667f0f.mdandimplementation_plan.mdunder reports) are fine; treat the namespaced path as canonical.
No [ESCALATE: PLANNER]. Plan is ready to implement after the §6 spikes.
[VERDICT: PASS]