Godopu
6c0b8b0084
- Bump MAM_VERSION to 4.0.0 in lib.sh - Bump all 8 skill frontmatter versions to 4.0.0 in 3-way lockstep - Update VERSIONS.md with v4.0.0 changelog, migration guide (B-1..B-5), and skill matrix - Archive multi-agent version upgrade consensus and peer review reports (439 passed, 0 failures)
38 lines
2.1 KiB
Markdown
38 lines
2.1 KiB
Markdown
# Review: v4.0.0 bump + version-upgrade consensus
|
||
|
||
- **Reviewer**: `reviewer-creator-grok-01`
|
||
- **Job**: `fc37a38a`
|
||
- **Artifacts**: `MAM_VERSION` / 8× `SKILL.md` / `VERSIONS.md` lockstep to `4.0.0`; `.agents/reports/version_upgrade_recommendation.md`
|
||
|
||
## Consensus document
|
||
|
||
Grok’s independent SemVer job `e0838148` (**v4.0.0**, `--agent cline` is a §8 break; hermes-only would be 3.2.0; highest-severity governs) is recorded accurately in §3. The 3/3 table, the internal-tool counter-argument rejection, and the deprecation-window miss all match what this session verified. No vote dilution.
|
||
|
||
Rev.2 of the recommendation (line-24 prose + orphan YAML rows) is reflected in the landed `VERSIONS.md` v4.0.0 B-1…B-4 notes.
|
||
|
||
## Lockstep implementation
|
||
|
||
| Surface | Status |
|
||
|---|---|
|
||
| `lib.sh` `MAM_VERSION="4.0.0"` | Met (not env-overridable) |
|
||
| `VERSIONS.md` current header `v4.0.0` | Met |
|
||
| Matrix prose + 8 skill cells `4.0.0` | Met (the line-24 sentence Rev.2 called out is updated) |
|
||
| 8 `SKILL.md` frontmatters `version: 4.0.0` | Met (create/stop/resume/status/monitor/delegate-job/loop/orc-onboard) |
|
||
| Historical `v3.1.0` changelog left at `MAM_VERSION="3.1.0"` | Correct |
|
||
|
||
`pytest tests/test_version_consistency.py` → **2 passed**.
|
||
|
||
v4.0.0 changelog states the actual break (`--agent cline` → exit 2), detection grep, pre-upgrade stop+purge, post-upgrade `atomic_dump_yaml` prune, and hermes additive work. That matches §6 of the recommendation.
|
||
|
||
## Residual nits (do not block)
|
||
|
||
1. **B-3 command spelling.** `multi-agent-mux-stop --session …` is not a PATH binary. Real entry is `bash .agents/skills/multi-agent-mux-stop/scripts/stop_session.sh` (as `deploy/INSTALL.md` already documents). Flags `--purge-conversation --yes --agent cline` are correct for v3.1.0-era stop.
|
||
2. The recommendation file still headers “Current version: v3.1.0” as a planning snapshot. Fine as an archived consensus; it is not the runtime source of truth.
|
||
3. “~14 releases since v1.2.0” is loose counting. Not load-bearing.
|
||
|
||
Grok’s **v4.0.0** recommendation is unchanged. No `[ESCALATE: PLANNER]`.
|
||
|
||
---
|
||
|
||
[VERDICT: PASS]
|