47 lines
2.4 KiB
Markdown
47 lines
2.4 KiB
Markdown
# Cross-review: documentation audit & cleanup (v4.1.3)
|
||
|
||
- **Reviewer**: `reviewer-creator-grok-01`
|
||
- **Job**: `901bfbe8`
|
||
- **Diff**: 8 files +57/−29, plus delete of root `mam-agent-creation-fix-report.md`. No `lib.sh` / `VERSIONS.md` / SKILL frontmatter version edits.
|
||
|
||
---
|
||
|
||
## 1. Cleanup
|
||
|
||
| Action | Assessment |
|
||
|---|---|
|
||
| Delete root `mam-agent-creation-fix-report.md` | **OK, not 유실.** Tracked copy remains `bug-report/mam-agent-creation-fix-report.md` (in HEAD). |
|
||
| Root `implementation_plan.md` kept | **OK.** It is the NATS messaging roadmap, distinct from `.agents/reports/implementation_plan.md` (OpenCode). Not a temp duplicate. |
|
||
|
||
## 2. Current-facing docs vs v4.1.3 / 5 agents
|
||
|
||
| File | What landed |
|
||
|---|---|
|
||
| `README.md` / `README.ko.md` | Badge v4.1.3; agents `claude, agy, hermes, grok, opencode`; `start_new_session=True` daemon isolation; loop + orc-onboard; resume flags for all five. |
|
||
| `BOOTSTRAP.md` / `.ko.md` | Same badge, agent list, loop/orc-onboard in tree. |
|
||
| `MULTI_AGENT_RULES.md` / `.ko.md` | `cline` dropped from Team Leaders examples; `grok`/`opencode` added. |
|
||
| `deploy/INSTALL.md` | Agent list adds OpenCode. |
|
||
| `deploy/README.md` | **Unchanged.** Packaging doc; no agent roster / version badge. Not a cline leftover. |
|
||
| `docs/*.md` | No `cline` hits in this sweep. |
|
||
|
||
Current-facing README/BOOTSTRAP/RULES have **no `cline`**. Remaining `cline` is historical (`VERSIONS.md` v4.0.0 changelog, `IMPROVEMENTS.md` old loop notes) — leave as history.
|
||
|
||
## 3. Resume `SKILL.md` (1acf4fb0 nit)
|
||
|
||
Empty-UUID branch now `case agy|hermes|opencode` (no `exit 1`) vs Class B `exit 1`. Spawn case includes `opencode`. Frontmatter still `version: 4.1.3`.
|
||
|
||
**Residual:** after Class A skips the error, the illustrative Workflow still sets `CMD_FULL` with `--conversation $UUID` / `--resume $UUID` / `--session $UUID` on an empty UUID, and `update_yaml_resumed.sh --uuid "$UUID"` without `--cmd-full`. Real `resume_session.sh` uses `spawn-spec`. Copy-paste of the Workflow block is still wrong for Class A 0-turn. Comment says the *script* handles fallback; the snippet does not.
|
||
|
||
Pitfall “Don't resume if the session is brand new and empty” is slightly stale vs Class A.
|
||
|
||
## 4. Lockstep
|
||
|
||
Unchanged: `lib.sh:32` `4.1.3`, `VERSIONS.md` header `v4.1.3`, 8 frontmatters `4.1.3`.
|
||
`pytest tests/test_version_consistency.py` → **2 passed**.
|
||
|
||
No `[ESCALATE: PLANNER]`.
|
||
|
||
---
|
||
|
||
[VERDICT: PASS]
|